Repository navigation
Migration readiness no longer fails a no-SQL PR whose base is one merge behind main - #4567
Merged
Merged
Conversation
…ive main tip The trusted checkout is the PR's own base, but both the collector and the publisher also required GITHUB_SHA (live main tip at trigger time) to equal it. Main moves every few minutes, so any PR whose base was one merge behind failed the runner before the migration-readiness check was even created. SQL PRs keep the strict current-main requirement. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012BMmZVXXXXXXXXXXXXXXX
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
migration-readinessrunner has been failing closed with no reason on PRs that have no SQL (#4559, #4556, #4555, #4560). The cause is a race with main, not the diffs.pull_request.base.sha).scripts/migration-pr-readiness.mjsandscripts/publish-migration-readiness.mjsalso requiredGITHUB_SHA(the live main tip when the event fired) to equal that base.migration-readinesscheck run is even created. That matches the pass on Vera proposes layout changes in the website editor, applied to the draft as one undo step (LIVE-2097) #4557 at 17:42 (base was the tip) and the failures after main moved.Change
HEAD === basefor every PR, and demandsGITHUB_SHA === base(plus base equals current main) only on the SQL path, which already required current main.GITHUB_SHAfrom its early gate. A no-SQL result is accepted; any SQL result still fails closed unlessGITHUB_SHA === base.pnpm vitest run scripts/migration-pr-readiness scripts/publish-migration: 114 passed.Notes
This is a trusted-path file. The runner executes main's copy, so PRs already open pick it up as soon as this merges and they are re-run. No SQL, no env change.
Generated by Claude Code