Fix RuboCop offenses in generated initializer - #5859
Open
RobertoBarros wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the generated Devise initializer to comply with the default RuboCop configuration included in newly generated Rails applications. Adds regression assertions for the affected generated lines.
Motivation
Running
bin/rubocopafter installing Devise in a new Rails 8.1 application reported eight offenses inconfig/initializers/devise.rb: two string literal offenses and six array spacing offenses.Verification
bundle exec ruby -Itest test/generators/install_generator_test.rb— 3 runs, 26 assertions, 0 failuresbin/test— 878 runs, 2,485 assertions, 0 failuresbin/rubocopin the generated application — 24 files inspected, no offenses detectedgit diff --checkpasses