Skip to content

feat(exec): publish authenticated review verdicts - #584

Open
andrei-hasna wants to merge 16 commits into
mainfrom
feat/authenticated-review-producer
Open

feat(exec): publish authenticated review verdicts#584
andrei-hasna wants to merge 16 commits into
mainfrom
feat/authenticated-review-producer

Conversation

@andrei-hasna

@andrei-hasna andrei-hasna commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add explicit opt-in authenticated review-event delivery to Hasna Identities
  • bind started and terminal events to an independently observed live GitHub/git merge candidate and acceptance scope
  • preserve structured app-server review output so missing, ambiguous, stale, or P0/P1 results fail closed

Verification

  • cargo metadata --format-version=1 --locked --no-deps -> exit 0
  • cargo fmt -- --config imports_granularity=Item -> exit 0 (stable rustfmt ignored the nightly-only import-granularity option)
  • git diff --check -> exit 0
  • secrets scan staged . --json -> findingCount: 0, 16 files scanned, no skipped files
  • Blacksmith Testbox compile/tests and canonical app-server schema generation are being run on this branch

Notes

  • delivery is omitted by default; the existing review path remains unchanged
  • reviewer credentials are accepted only from HASNA_IDENTITIES_REVIEW_API_KEY and are sent only as an Authorization header
  • the Identities ingress contract is pinned locally because this producer and the receiving package are bootstrapping together

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@andrei-hasna
andrei-hasna force-pushed the feat/authenticated-review-producer branch from af9b977 to e2d3609 Compare August 13, 2026 09:46
Bind explicit review delivery to the live pull request candidate and preserve structured reviewer output so missing, stale, or blocking results fail closed.

Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
Agent: agent-chief-engineering
@andrei-hasna
andrei-hasna force-pushed the feat/authenticated-review-producer branch from 62b48c1 to d38237f Compare August 13, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant