fix(app-server): redact command execution display - #583
Open
andrei-hasna wants to merge 7 commits into
Open
Conversation
Add Testbox regression coverage for bearer-token redaction in command execution display items and sanitizer support for bearer token alphabets. Agent: Hortensia-404
Redact bearer-like secrets from app-server command execution display items across live events, terminal items, guardian projections, and replay reconstruction while leaving executable approval request parameters unchanged. Task: 4ce43a71-c3c6-4a7b-b378-f6b59866451f Agent: Hortensia-404
Tighten the bearer-token redaction order so bearer credentials with OpenAI-style prefixes and +suffix text are consumed as one bearer token before generic key redaction can split them. Regenerate the affected app-server schema fixtures so commandExecution display fields are documented as redacted display values while approval request schemas keep the raw executable command contract. Task: 4ce43a71-c3c6-4a7b-b378-f6b59866451f Agent: Hortensia-404
Regenerate the command execution display schema fixture descriptions to match write-app-server-schema output after the redacted-display doc change. Task: 4ce43a71-c3c6-4a7b-b378-f6b59866451f Agent: Hortensia-404
Match the JSON commandActions schema descriptions to the current write-app-server-schema wrapping. Task: 4ce43a71-c3c6-4a7b-b378-f6b59866451f Agent: Hortensia-404
Keep the aggregate approval request schema aligned with write-app-server-schema while leaving ThreadItem command display docs redacted. Task: 4ce43a71-c3c6-4a7b-b378-f6b59866451f Agent: Hortensia-404
Contributor
Author
|
[REVIEW] NO_GO — #583 @ 2995fec — lens: correctness+security+gates, reviewer Trebius (1 of 1) Reviewed:
Forge checks read by name and conclusion:
Blocking P0/P1 finding:
Non-blocking follow-ups:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
App-server command-execution display items can expose bearer-shaped values embedded in rendered commands and parsed command actions. Client-facing live, completed, and replayed items must be sanitized without changing the original command or actions used for approval and execution.
This is the app-server display-projection fix tracked by Todos task
4ce43a71-c3c6-4a7b-b378-f6b59866451f(OPE2-00351). It does not overlap PR #580 or the separate exec-output and interactive-history tasks.What changed
Verification
46ec165765e085ee23898e64d3718777a92c5c1d.31675994660: expected regression failure atcommand_execution_display_redacts_secrets_and_round_trips, proving the display projection still serialized the credential before the fix.f17228c771dd1727f9aaf95cb84ad7f8f6fe5c1f.31676996079: pending on the exact fix candidate when this PR was opened; this body will be updated with the terminal result.Landing state
Do not merge from this PR yet. The exact candidate remains subject to the recorded Blacksmith, scan, and independent-review gates.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.