Fix completion contexts in nested scopes#4969
Open
crtschin wants to merge 4 commits into
Open
Conversation
Replaces the inline getCContext with a Context module computed per request from the parsed module.
crtschin
force-pushed
the
crtschin/completion-context-refactor
branch
from
3eefc7f to
5e16bde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous completion code took the first context returned through descent into the AST.
Moved context determination into it's own module and adjusted the descent to keep track of the "tightest" context around the cursor. Same caveat applies as #4910, I don't compare columns so the it has better support for invalid parses which are common while typing.
This doesn't contain the top-level snippet from #4905 yet, that'll be in a follow-up.