Eagerly perform set insertions in nub{Ord,Int}#1229
Open
meooow25 wants to merge 1 commit into
Open
Conversation
Currently we create thunks for <insert x s> at every step that get forced at the next step when we check for set membership. Here we change the insertions to be eager. This means doing a bit of work upfront that would otherwise be pushed to the next step but without the overhead of creating a thunk for it, which reduces a noticeable amount of allocations overall. The go functions can also be marked as strict in the input set now. Benchmarks on GHC 9.14 show a decrease in allocations of 8% on nubOrd.noFusion_distinct and nubOrd.strings_noFusion_distinct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we create thunks for at every step that get forced at the next step when we check for set membership. Here we change the insertions to be eager. This means doing a bit of work upfront that would otherwise be pushed to the next step but without the overhead of creating a thunk for it, which reduces a noticeable amount of allocations overall.
The go functions can also be marked as strict in the input set now.
Benchmarks on GHC 9.14 show a decrease in allocations of 8% on nubOrd.noFusion_distinct and nubOrd.strings_noFusion_distinct.