Add filterTree to Data.Tree#1226
Open
tchoutri wants to merge 1 commit into
Open
Conversation
Sponsored-By: Scrive AB
Contributor
|
Hi, thanks for the PR. However there are multiple possible implementations for a "filterTree". As an example, a different "treefilter" was proposed in #39. Hoogle shows yet another possible implementation used in hedgehog here. So I am not convinced that this one is particular deserves to be included in Data.Tree. |
Author
|
@meooow25 yeah of course, you should benchmark the possible implementations, I just had to write one for work and I thought I'd upstream it, since there wasn't one available in Data.Tree. :) |
Contributor
|
I don't mean that these implementation differ in efficiency (which is also something to consider, of course), but that they have different behaviors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@meooow25 Hi, I'd like to upstream a filter function we have at work for Trees. Happy to include a property test if you have something that you'd like tested specifically.