Fix assert stanza disabled not available#12080
Open
philderbeast wants to merge 2 commits into
Open
Conversation
philderbeast
force-pushed
the
fix/assert-stanza-disabled-not-available
branch
3 times, most recently
from
ce31f0a to
6078c65
Compare
10 tasks
6 tasks
- Fix assertion failure wrt haskell#11568 'lookupLocalPackageConfig' would ignore --'projectConfigAllPackages' (`package *`) and thus diverge from 'lookupPerPkgOption'. This would then cause further divergence between 'elabStanzasRequested' and 'elabStanzasAvailable'. Change arg order with perPkgOptionFlag, def first Use function composition for perPkgOption* Add type sigs for all perPkgOption* functions Inline each perPkgOption* only used once Use -XViewPatterns in perPkgOptionLibExeFlag Partially apply then use lookupPerPkgOption Move Map.fromList in list comprehension Use -XViewPattern in Just pkgId branch Defer (TestStanzas,) & (BenechStanzas,) tuples Remove lookupLocalPackageConfig Co-Authored-By: Julian Ospald <hasufell@posteo.de>
philderbeast
force-pushed
the
fix/assert-stanza-disabled-not-available
branch
from
6078c65 to
09d9332
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11568. This is the work of @hasufell in #11567 but isolated and extracted to only fix the assertion.
Note
Tests were added previously in #12069. The assertion was removed then. We add it back with this fix.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.