Fixed bug when deleting hashlist - #2460
Open
jessevz wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes deletion of a hashlist that belongs to one or more superhashlists when the member hashlist has 0 hashes and/or 0 cracked entries, by avoiding invalid decrement operations that previously threw.
Changes:
- Guard superhashlist counter decrements during member-hashlist deletion to avoid
dec(..., 0)exceptions. - Add an API v2 regression test covering deletion of a superhashlist member with zero cracked entries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/inc/utils/HashlistUtils.php | Adds conditional guards around superhashlist dec() calls to prevent errors when decrement amounts are zero. |
| ci/apiv2/test_hashlist.py | Adds a regression test to ensure deleting a superhashlist member with zero cracked entries succeeds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2458