Typing rework and warning fixes#2303
Merged
Merged
Conversation
…t some duplicate line elements), not sure if the newly added test works
# Conflicts: # src/inc/apiv2/model/SupertaskAPI.php
…es it uses now AbstractModel which is declared as template so that code inspection and typing understand it
jessevz
approved these changes
Jul 8, 2026
jessevz
approved these changes
Jul 9, 2026
jessevz
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to update phpdocs and typing to get better coverage and discover further potential issues.
Main change in typing:
objectfor everything, it is replaced by using AbstractModel now which is declared as template.Also the change of the DBA handling for the typing should have a large performance effect as it gets rid of all the unnecessary serialization/de-serialization which happened so far.