Skip to content

SRE-999: Remove cache: false from the Petrinaut library builds - #9648

Open
claude[bot] wants to merge 4 commits into
mainfrom
td/sre-999-cache-petrinaut-library-builds
Open

SRE-999: Remove cache: false from the Petrinaut library builds#9648
claude[bot] wants to merge 4 commits into
mainfrom
td/sre-999-cache-petrinaut-library-builds

Conversation

@claude

@claude claude Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Requested by Tim Diekmann · Slack thread

🌟 What is the purpose of this PR?

@hashintel/petrinaut, @hashintel/petrinaut-core and @hashintel/petrinaut-cli each set "cache": false on their build task, so Turborepo rebuilt them from scratch on every run, locally and in CI. Nothing in the repository records a reason for it: the flag was copy-pasted from libs/@hashintel/petrinaut when the other two packages were split out of it, and it has been carried along since.

Each of the three already declares "outputs": ["dist/**"], which is the complete set of files its build writes. None of them reads anything outside its own package, and none inlines an environment value into the built output. Caching these builds is therefore safe, and this PR turns it back on by deleting the three "cache": false lines.

🔗 Related links

🔍 What does this change?

  • Removes "cache": false from the build task in the turbo.json of the three packages.
  • Regenerates each package's committed docs/task-dependencies.json to match. That file records the resolved cache value per task, and the Validate Task Dependencies step of the Global lint job fails on any diff between the committed copy and a fresh generation.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • affected the execution graph, and the turbo.json's have been updated to reflect this

🛡 What tests cover this?

CI. Validate Task Dependencies checks that the regenerated task-dependency docs match what is committed here, and the normal build and test jobs run the three builds through the cache.

❓ How to test this?

  1. Check out the branch.
  2. Run a build of one of the three packages twice, e.g. turbo run build --filter @hashintel/petrinaut-core.
  3. Confirm the second run reports a cache hit rather than rebuilding, and that dist/ matches the first run's output.

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hash Ready Ready Preview Sep 10, 2026 11:09pm UTC
petrinaut Ready Ready Preview Sep 10, 2026 11:09pm UTC
petrinaut-docs Ready Ready Preview Sep 10, 2026 11:09pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
hashdotdesign-tokens Ignored Ignored Preview Sep 10, 2026 11:09pm UTC

Request Review

@cursor

cursor Bot commented Sep 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Only Turborepo task metadata changes; build outputs and dependencies are unchanged, with caching considered safe because builds write only to dist/**.

Overview
Re-enables Turborepo caching for build on @hashintel/petrinaut, @hashintel/petrinaut-core, and @hashintel/petrinaut-cli by removing stale "cache": false from each package’s turbo.json. Those tasks already declare outputs": ["dist/**"], so repeated runs can hit the cache instead of rebuilding every time locally and in CI.

The committed docs/task-dependencies.json files for the same packages are updated so they no longer record cache: false, keeping them in sync with what //#doc:task-dependencies generates and what CI’s Validate Task Dependencies step expects.

Reviewed by Cursor Bugbot for commit 425322f. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d47f7a6. Configure here.

Comment thread libs/@hashintel/petrinaut-core/turbo.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants