Skip to content

FE-1235 Update supply-chain-profit-model naming conventions#9076

Merged
kube merged 2 commits into
mainfrom
yz/fe-1235-supply-chain-profit-naming-conventions
Jul 20, 2026
Merged

FE-1235 Update supply-chain-profit-model naming conventions#9076
kube merged 2 commits into
mainfrom
yz/fe-1235-supply-chain-profit-naming-conventions

Conversation

@YannisZa

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Rename "Profit" to "Adjusted Profit"
Rename reorder_threshold to replenishment_aggressiveness (integer valued that controls whether raw material replenishment happens at all or not and contributes to the rate of replenishment)
Show only the two scenarios called "Empty Stock" (no raw materials and finished goods) and "Rich stock" (200 raw materials and 100 finished goods)

🔗 Related links

FE-1235 Internal

🚫 Blocked by

  • ...

🔍 What does this change?

  • ...

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing
  • modifies an npm-publishable library and I have added a changeset file(s)
  • modifies a Cargo-publishable library and I have amended the version
  • modifies a Cargo-publishable library, but it is not yet ready to publish
  • modifies a block that will need publishing via GitHub action once merged
  • I am unsure / need advice

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change
  • are in a state where docs changes are not yet required but will be
  • require changes to docs which are made as part of this PR
  • require changes to docs which are not made in this PR
    • Provide more detail here
  • I am unsure / need advice

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph
  • affected the execution graph, and the turbo.json's have been updated to reflect this
  • I am unsure / need advice

⚠️ Known issues

🐾 Next steps

🛡 What tests cover this?

❓ How to test this?

  1. Checkout the branch / view the deployment
  2. Try X
  3. Confirm that Y

📹 Demo

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Jul 20, 2026 8:39pm
petrinaut Ready Ready Preview, Comment Jul 20, 2026 8:39pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview Jul 20, 2026 8:39pm

@cursor

cursor Bot commented Jul 20, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Example-model and naming-only changes with no runtime logic beyond parameter keys and scenario lists; downstream manifests or docs that still use old identifiers may break until updated.

Overview
Updates the supply-chain profit Petrinaut example in supply-chain-profit.ts and the matching CLI JSON so naming and scenarios match FE-1235.

Parameter rename: reorder_threshold becomes replenishment_aggressiveness (ids, scenario bindings, and the raw replenishment lambda still use the same “gap above 80” logic).

Metric label: The objective is shown as Adjusted profit (description updated; metric_profit id unchanged).

Scenarios: Drops the baseline vs demand-surge matrix and keeps two cases—Rich stock (200 raw / 100 finished) and Empty stock (zero inventory)—with shorter ids/descriptions. Surge-style tuning defaults remain on those two rows, but demand_multiplier defaults to 1 instead of 1.35.

Callers that still pass reorder_threshold, request metric Profit, or reference removed scenario ids need to follow the new names (optimization manifest/docs are outside this diff).

Reviewed by Cursor Bugbot for commit 15f0b14. Bugbot is set up for automated code reviews on this repo. Configure here.

@YannisZa
YannisZa requested a review from kube July 20, 2026 20:19
@github-actions github-actions Bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team labels Jul 20, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7476cd3. Configure here.

kube
kube previously approved these changes Jul 20, 2026
@kube
kube enabled auto-merge July 20, 2026 20:21
@vercel
vercel Bot temporarily deployed to Preview – petrinaut July 20, 2026 20:22 Inactive
@YannisZa
YannisZa requested a review from kube July 20, 2026 20:23
@kube
kube added this pull request to the merge queue Jul 20, 2026
Merged via the queue into main with commit 4a1d584 Jul 20, 2026
61 checks passed
@kube
kube deleted the yz/fe-1235-supply-chain-profit-naming-conventions branch July 20, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants