Skip to content

BE-576: Upgrade @napi-rs/cli and napi crates to v3#8752

Open
indietyp wants to merge 3 commits into
mainfrom
bm/be-576-update-napi-to-v3
Open

BE-576: Upgrade @napi-rs/cli and napi crates to v3#8752
indietyp wants to merge 3 commits into
mainfrom
bm/be-576-update-napi-to-v3

Conversation

@indietyp
Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

This upgrades the napi-rs ecosystem to its latest major versions — bumping @napi-rs/cli from 2.18.4 to 3.6.2 and the corresponding Rust crates (napi, napi-derive, napi-build, napi-sys) from v2 to v3. This brings in breaking changes to the NAPI build tooling, requiring updates to how build targets are declared and how the CLI output directory is specified.

🔗 Related links

🔍 What does this change?

  • Upgrades @napi-rs/cli from 2.18.4 to 3.6.2 in the mise config.
  • Upgrades napi to 3.9.0, napi-derive to 3.5.6, napi-build to 2.3.2, and napi-sys to 3.2.1 in Cargo.toml.
  • Enables the type-def feature on napi-derive to support TypeScript type definition generation.
  • Updates the effect-dns-hickory build scripts to use the new CLI flag syntax (-o dist instead of positional dist argument).
  • Migrates the napi config in effect-dns-hickory/package.json from the old name/triples format to the new buildName/targets format, explicitly listing all supported targets including x86_64-unknown-linux-gnu, x86_64-pc-windows-msvc, and x86_64-apple-darwin.
  • Removes the now-unused convert_case 0.6.0 and ctor 0.2.9 transitive dependencies, replacing them with convert_case 0.11.0 and ctor 1.0.6.
  • Updates libloading from 0.8.9 to 0.9.0.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🛡 What tests cover this?

  • Existing build and integration tests for effect-dns-hickory.

❓ How to test this?

  1. Checkout the branch.
  2. Run yarn build in libs/@local/effect-dns/hickory.
  3. Confirm the native module builds successfully and the generated impl.js and impl.d.ts files are emitted to dist.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment May 26, 2026 8:12am
hashdotdesign-tokens Ready Ready Preview, Comment May 26, 2026 8:12am
petrinaut Ready Ready Preview May 26, 2026 8:12am

@cursor
Copy link
Copy Markdown

cursor Bot commented May 26, 2026

PR Summary

Medium Risk
Touches the native Node addon build and cross-platform target matrix for effect-dns-hickory; no app auth or data-path changes, but a broken build blocks that package.

Overview
Upgrades the napi-rs toolchain to v3: @napi-rs/cli in mise, workspace napi / napi-derive / napi-build / napi-sys in Cargo.toml, and Cargo.lock refresh (including newer libloading and ctor).

For @local/effect-dns-hickory, build scripts now pass -o dist instead of a positional output path, regenerate-packages uses napi create-npm-dirs, and the napi block switches from name/triples to binaryName / targets with an explicit list of seven triples (including x86_64 Linux/macOS/Windows). Workspace napi-derive enables the type-def feature for TS generation.

.gitignore adds libs/@local/effect-dns/hickory/npm for v3-generated npm layout artifacts.

Reviewed by Cursor Bugbot for commit 243bc3a. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/deps Relates to third-party dependencies (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team labels May 26, 2026
Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 26, 2026

🤖 Augment PR Summary

Summary: Upgrades the repo’s NAPI-RS toolchain to the v3 ecosystem to match the latest breaking changes in build/config conventions.

Changes:

  • Bumps @napi-rs/cli from 2.18.4 → 3.6.2 in mise
  • Updates Rust dependencies (napi, napi-derive, napi-build) to the v3-compatible versions and enables TS type-def generation
  • Adjusts effect-dns-hickory build scripts to use -o dist instead of positional output args
  • Migrates the package’s NAPI config from triples to an explicit targets list

Technical Notes: This aligns the native build + binding generation with the v3 CLI option/config schema to keep cross-platform builds working.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread libs/@local/effect-dns/hickory/package.json Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9194f71. Configure here.

Comment thread libs/@local/effect-dns/hickory/package.json Outdated
Comment thread libs/@local/effect-dns/hickory/package.json
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.97%. Comparing base (cb459a8) to head (243bc3a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8752      +/-   ##
==========================================
+ Coverage   58.81%   58.97%   +0.15%     
==========================================
  Files        1328     1340      +12     
  Lines      126811   129010    +2199     
  Branches     5790     5832      +42     
==========================================
+ Hits        74580    76079    +1499     
- Misses      51350    52033     +683     
- Partials      881      898      +17     
Flag Coverage Δ
apps.hash-ai-worker-ts 1.41% <ø> (ø)
apps.hash-api 0.00% <ø> (ø)
blockprotocol.type-system 40.84% <ø> (ø)
local.claude-hooks 0.00% <ø> (ø)
local.harpc-client 51.24% <ø> (ø)
local.hash-backend-utils 2.81% <ø> (ø)
local.hash-graph-sdk 9.63% <ø> (ø)
local.hash-isomorphic-utils 0.00% <ø> (ø)
rust.antsi 0.00% <ø> (ø)
rust.error-stack 90.87% <ø> (ø)
rust.harpc-codec 84.70% <ø> (ø)
rust.harpc-net 96.21% <ø> (-0.02%) ⬇️
rust.harpc-tower 67.03% <ø> (ø)
rust.harpc-types 0.00% <ø> (ø)
rust.harpc-wire-protocol 92.23% <ø> (ø)
rust.hash-codec 72.76% <ø> (ø)
rust.hash-graph-api 2.52% <ø> (ø)
rust.hash-graph-authorization 62.34% <ø> (ø)
rust.hash-graph-postgres-store 26.74% <ø> (-0.07%) ⬇️
rust.hash-graph-store 37.76% <ø> (ø)
rust.hash-graph-temporal-versioning 47.95% <ø> (ø)
rust.hash-graph-types 0.00% <ø> (ø)
rust.hash-graph-validation 83.45% <ø> (ø)
rust.hashql-ast 87.23% <ø> (ø)
rust.hashql-compiletest 28.26% <ø> (-1.38%) ⬇️
rust.hashql-core 79.25% <ø> (ø)
rust.hashql-diagnostics 72.53% <ø> (ø)
rust.hashql-eval 75.88% <ø> (-1.66%) ⬇️
rust.hashql-hir 89.06% <ø> (ø)
rust.hashql-mir 86.76% <ø> (ø)
rust.hashql-syntax-jexpr 94.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 26, 2026

Merging this PR will not alter performance

✅ 80 untouched benchmarks


Comparing bm/be-576-update-napi-to-v3 (243bc3a) with main (ae5c317)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (cb459a8) during the generation of this report, so ae5c317 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@vercel vercel Bot temporarily deployed to Preview – petrinaut May 26, 2026 07:57 Inactive
@github-actions
Copy link
Copy Markdown
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

policy_resolution_large

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 2002 $$29.9 \mathrm{ms} \pm 219 \mathrm{μs}\left({\color{red}5.20 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$3.77 \mathrm{ms} \pm 20.3 \mathrm{μs}\left({\color{gray}4.82 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 1001 $$15.4 \mathrm{ms} \pm 112 \mathrm{μs}\left({\color{red}23.8 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 3314 $$47.6 \mathrm{ms} \pm 357 \mathrm{μs}\left({\color{red}9.26 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$15.5 \mathrm{ms} \pm 126 \mathrm{μs}\left({\color{gray}0.845 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 1526 $$25.7 \mathrm{ms} \pm 248 \mathrm{μs}\left({\color{red}5.50 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 2078 $$33.9 \mathrm{ms} \pm 204 \mathrm{μs}\left({\color{red}15.8 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$4.24 \mathrm{ms} \pm 39.4 \mathrm{μs}\left({\color{red}7.07 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 1033 $$16.9 \mathrm{ms} \pm 107 \mathrm{μs}\left({\color{red}17.8 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_medium

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 102 $$4.68 \mathrm{ms} \pm 33.0 \mathrm{μs}\left({\color{red}20.6 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$3.63 \mathrm{ms} \pm 21.1 \mathrm{μs}\left({\color{red}18.7 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 51 $$4.13 \mathrm{ms} \pm 26.0 \mathrm{μs}\left({\color{red}20.1 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 269 $$6.42 \mathrm{ms} \pm 38.1 \mathrm{μs}\left({\color{red}21.4 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$4.29 \mathrm{ms} \pm 30.1 \mathrm{μs}\left({\color{red}19.8 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 107 $$5.04 \mathrm{ms} \pm 37.8 \mathrm{μs}\left({\color{red}20.7 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 133 $$5.68 \mathrm{ms} \pm 31.4 \mathrm{μs}\left({\color{red}24.0 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$4.28 \mathrm{ms} \pm 26.4 \mathrm{μs}\left({\color{red}22.0 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 63 $$5.18 \mathrm{ms} \pm 38.6 \mathrm{μs}\left({\color{red}20.7 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_none

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 2 $$3.15 \mathrm{ms} \pm 21.8 \mathrm{μs}\left({\color{red}13.3 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$3.08 \mathrm{ms} \pm 17.3 \mathrm{μs}\left({\color{red}11.3 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 1 $$3.20 \mathrm{ms} \pm 15.5 \mathrm{μs}\left({\color{red}13.3 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 8 $$3.55 \mathrm{ms} \pm 27.5 \mathrm{μs}\left({\color{red}14.1 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$3.34 \mathrm{ms} \pm 20.8 \mathrm{μs}\left({\color{red}14.4 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 3 $$3.70 \mathrm{ms} \pm 28.4 \mathrm{μs}\left({\color{red}15.9 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_small

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 52 $$3.60 \mathrm{ms} \pm 21.5 \mathrm{μs}\left({\color{red}13.5 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$3.16 \mathrm{ms} \pm 21.0 \mathrm{μs}\left({\color{red}9.45 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 25 $$3.42 \mathrm{ms} \pm 21.1 \mathrm{μs}\left({\color{red}12.1 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 94 $$4.10 \mathrm{ms} \pm 24.0 \mathrm{μs}\left({\color{red}11.6 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$3.44 \mathrm{ms} \pm 19.5 \mathrm{μs}\left({\color{red}9.30 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 26 $$3.93 \mathrm{ms} \pm 34.2 \mathrm{μs}\left({\color{red}15.4 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 66 $$3.92 \mathrm{ms} \pm 24.3 \mathrm{μs}\left({\color{red}9.83 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$3.55 \mathrm{ms} \pm 27.5 \mathrm{μs}\left({\color{red}11.4 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 29 $$3.82 \mathrm{ms} \pm 25.0 \mathrm{μs}\left({\color{red}9.85 \mathrm{\%}}\right) $$ Flame Graph

read_scaling_complete

Function Value Mean Flame graphs
entity_by_id;one_depth 1 entities $$50.6 \mathrm{ms} \pm 372 \mathrm{μs}\left({\color{red}12.9 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 10 entities $$94.7 \mathrm{ms} \pm 538 \mathrm{μs}\left({\color{red}13.2 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 25 entities $$54.9 \mathrm{ms} \pm 322 \mathrm{μs}\left({\color{red}5.44 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 5 entities $$57.3 \mathrm{ms} \pm 422 \mathrm{μs}\left({\color{red}9.86 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 50 entities $$69.6 \mathrm{ms} \pm 384 \mathrm{μs}\left({\color{red}8.72 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 1 entities $$51.5 \mathrm{ms} \pm 329 \mathrm{μs}\left({\color{red}5.73 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 10 entities $$450 \mathrm{ms} \pm 1.30 \mathrm{ms}\left({\color{gray}3.97 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 25 entities $$99.7 \mathrm{ms} \pm 622 \mathrm{μs}\left({\color{lightgreen}-5.910 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 5 entities $$101 \mathrm{ms} \pm 431 \mathrm{μs}\left({\color{red}6.81 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 50 entities $$340 \mathrm{ms} \pm 1.36 \mathrm{ms}\left({\color{gray}1.09 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 1 entities $$20.9 \mathrm{ms} \pm 112 \mathrm{μs}\left({\color{gray}0.642 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 10 entities $$21.2 \mathrm{ms} \pm 114 \mathrm{μs}\left({\color{gray}-0.303 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 25 entities $$21.1 \mathrm{ms} \pm 100.0 \mathrm{μs}\left({\color{gray}-2.371 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 5 entities $$21.9 \mathrm{ms} \pm 115 \mathrm{μs}\left({\color{gray}0.692 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 50 entities $$25.4 \mathrm{ms} \pm 126 \mathrm{μs}\left({\color{gray}-4.716 \mathrm{\%}}\right) $$ Flame Graph

read_scaling_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$20.1 \mathrm{ms} \pm 112 \mathrm{μs}\left({\color{lightgreen}-7.618 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$20.2 \mathrm{ms} \pm 109 \mathrm{μs}\left({\color{lightgreen}-8.111 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$20.1 \mathrm{ms} \pm 108 \mathrm{μs}\left({\color{lightgreen}-10.127 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$20.3 \mathrm{ms} \pm 105 \mathrm{μs}\left({\color{lightgreen}-10.392 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$26.5 \mathrm{ms} \pm 167 \mathrm{μs}\left({\color{lightgreen}-9.255 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$37.1 \mathrm{ms} \pm 335 \mathrm{μs}\left({\color{gray}-1.741 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$35.9 \mathrm{ms} \pm 291 \mathrm{μs}\left({\color{gray}-4.267 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$36.3 \mathrm{ms} \pm 329 \mathrm{μs}\left({\color{gray}-3.627 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$37.5 \mathrm{ms} \pm 239 \mathrm{μs}\left({\color{gray}-1.600 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$35.9 \mathrm{ms} \pm 326 \mathrm{μs}\left({\color{lightgreen}-8.443 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$37.3 \mathrm{ms} \pm 296 \mathrm{μs}\left({\color{gray}2.41 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$35.7 \mathrm{ms} \pm 313 \mathrm{μs}\left({\color{gray}-1.788 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$34.9 \mathrm{ms} \pm 267 \mathrm{μs}\left({\color{lightgreen}-5.317 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$35.4 \mathrm{ms} \pm 299 \mathrm{μs}\left({\color{lightgreen}-6.962 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: bf5a9ef5-dc3b-43cf-a291-6210c0321eba $$8.77 \mathrm{ms} \pm 47.9 \mathrm{μs}\left({\color{gray}-4.574 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property traversal_paths=0 0 $$98.2 \mathrm{ms} \pm 534 \mathrm{μs}\left({\color{gray}-4.519 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=255 1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true $$163 \mathrm{ms} \pm 984 \mathrm{μs}\left({\color{red}5.84 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false $$108 \mathrm{ms} \pm 648 \mathrm{μs}\left({\color{gray}-0.355 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true $$116 \mathrm{ms} \pm 631 \mathrm{μs}\left({\color{gray}-0.224 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true $$126 \mathrm{ms} \pm 658 \mathrm{μs}\left({\color{gray}0.989 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true $$140 \mathrm{ms} \pm 588 \mathrm{μs}\left({\color{red}5.32 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=0 0 $$107 \mathrm{ms} \pm 500 \mathrm{μs}\left({\color{gray}0.187 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=255 1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true $$140 \mathrm{ms} \pm 828 \mathrm{μs}\left({\color{gray}0.489 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false $$113 \mathrm{ms} \pm 485 \mathrm{μs}\left({\color{gray}0.696 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true $$123 \mathrm{ms} \pm 663 \mathrm{μs}\left({\color{gray}0.759 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true $$127 \mathrm{ms} \pm 578 \mathrm{μs}\left({\color{gray}1.42 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true $$133 \mathrm{ms} \pm 967 \mathrm{μs}\left({\color{red}7.06 \mathrm{\%}}\right) $$

scenarios

Function Value Mean Flame graphs
full_test query-limited $$148 \mathrm{ms} \pm 710 \mathrm{μs}\left({\color{red}8.91 \mathrm{\%}}\right) $$ Flame Graph
full_test query-unlimited $$162 \mathrm{ms} \pm 725 \mathrm{μs}\left({\color{red}9.96 \mathrm{\%}}\right) $$ Flame Graph
linked_queries query-limited $$113 \mathrm{ms} \pm 652 \mathrm{μs}\left({\color{gray}3.31 \mathrm{\%}}\right) $$ Flame Graph
linked_queries query-unlimited $$559 \mathrm{ms} \pm 1.24 \mathrm{ms}\left({\color{gray}-2.041 \mathrm{\%}}\right) $$ Flame Graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team

Development

Successfully merging this pull request may close these issues.

1 participant