Skip to content

FE-1232: Report comparison evidence#346

Merged
kostandinang merged 8 commits into
nextfrom
ka/fe-1232-comparison-reporting-skills
Jul 21, 2026
Merged

FE-1232: Report comparison evidence#346
kostandinang merged 8 commits into
nextfrom
ka/fe-1232-comparison-reporting-skills

Conversation

@kostandinang

@kostandinang kostandinang commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Why

Comparison findings need a reusable publication path that does not blur Notion editing with validity, contamination, test design, judging, and redaction policy.

What

Add two separate, composable project skills:

  • /notion-reporting — triggers when a user asks to create or revise a Notion report, summarize findings on a Notion page, or add an overview or side note. It discovers the live Notion MCP surface, fetches before editing, applies the smallest safe mutation, preserves child content, and fetches again to verify the result.
  • /comparison-reporting — triggers when designing or reporting elicitation, execution, or end-to-end comparison campaigns. It freezes test axes, rubrics, judge protocol, and repeat contracts; evaluates validity before outcomes; separates procedure determinism from output similarity; classifies implementation/runtime/protocol issues; and builds requirement-level elicitation-to-implementation traceability.

The comparison skill also enforces masked/unblinded/controller-only evidence boundaries and composes with /notion-reporting only for safe Notion formatting and mutation.

A dependency-free contract check pins skill discovery metadata, direct references, mutation safety, campaign-design guardrails, invalid-attempt retention, controller-only redaction, and the rule against unsupported winner or determinism claims.

Example use:

/comparison-reporting
Design a greenfield whole-app campaign with a frozen rubric and masked judge protocol, then report the resulting elicitation, execution, determinism, and end-to-end evidence to <Notion URL>.
/notion-reporting
Update <Notion URL> with an overview, problem, result, findings, limitations, and side note from this evidence.

How to test

Automated

  1. npm run check:skills
    • Expected: the existing 21 ln-* contracts and both reporting-skill contracts pass.
  2. npx oxlint scripts/check-reporting-skills.mjs
  3. npx oxfmt --check scripts/check-reporting-skills.mjs
  4. npx remark .agents/skills/comparison-reporting/SKILL.md .agents/skills/comparison-reporting/references/*.md --quiet --frail
  5. npm run check:promoted-run-paths
  6. npm run build
  7. Use the PR Full gate as the authoritative test result.

Local npm test currently reaches 2,490 passing tests before the unrelated standalone-web-session-host.tui-differential.test.ts baseline race fails with “Agent is already processing”; the focused rerun reproduces it without any reporting-skill code involved.

Manual skill smoke

  1. Start a new agent chat so project skills are rediscovered.
  2. Invoke /comparison-reporting for a planned campaign and confirm it freezes codebase mode, change scope, interface type, plan stability, sample/repeat count, rubric, winner rule, and judge protocol before outcomes.
  3. Supply repeated execution attempts and confirm the report separates canonical transition/action sequence evidence from generated-output structural similarity and bounds the determinism claim by valid attempt count.
  4. Supply a matched elicitation-to-execution case and confirm it produces requirement rows for explicitly elicited, inferred, implemented, missed, and verified outcomes without making a causal claim from one pair.
  5. Publish through /notion-reporting and confirm fetch-before-edit, one targeted mutation, preserved child pages/databases, and post-write verification.

kostandinang commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kostandinang
kostandinang marked this pull request as ready for review July 20, 2026 18:16
@cursor

cursor Bot commented Jul 20, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation and agent-skill guidance only, with no product runtime or schema changes; risk is limited to incorrect external Notion edits if agents misapply the skills.

Overview
Introduces two project-local agent skills for safe Notion publication and validity-first comparison reporting, with reference docs for elicitation, execution, end-to-end traceability, frozen campaign strategy, and example report wording.

/notion-reporting covers MCP discovery, fetch-before-edit, smallest safe mutations (preserving child pages/databases), and post-write verification. /comparison-reporting stays separate: it classifies comparison kind, orders evidence (validity before outcomes), enforces masked/unblinded/controller-only boundaries, blocks unsupported winners and causal overreach, and composes with Notion reporting only for formatting—not for evidence policy. Active procedures like /compare-specs are explicitly not retrofitted with rigorous campaign machinery.

scripts/check-reporting-skills.mjs pins safety-critical phrases, validates skill metadata, forbids exposing the execution case root in public evidence, and recursively checks relative Markdown links. npm run check:skills now runs this after the existing ln-* check (renamed log labels in check-ln-skills.mjs). A patch changeset and memory/PLAN.md record FE-1232 completion.

Reviewed by Cursor Bugbot for commit fdd581f. Bugbot is set up for automated code reviews on this repo. Configure here.

@kostandinang
kostandinang changed the base branch from ka/fe-1230-greenfield-execution-comparison-tracer to graphite-base/346 July 20, 2026 19:42
@kostandinang
kostandinang force-pushed the ka/fe-1232-comparison-reporting-skills branch from 072e6e3 to 426ce55 Compare July 20, 2026 19:43
@kostandinang
kostandinang changed the base branch from graphite-base/346 to ka/fe-1230-greenfield-execution-comparison-tracer July 20, 2026 19:43
Comment thread .agents/skills/comparison-reporting/SKILL.md Outdated
Comment thread .agents/skills/notion-reporting/SKILL.md Outdated
@kostandinang
kostandinang changed the base branch from ka/fe-1230-greenfield-execution-comparison-tracer to graphite-base/346 July 20, 2026 19:45
@kostandinang
kostandinang force-pushed the ka/fe-1232-comparison-reporting-skills branch from 426ce55 to 0cf343b Compare July 20, 2026 19:46
@kostandinang
kostandinang changed the base branch from graphite-base/346 to ka/fe-1230-greenfield-execution-comparison-tracer July 20, 2026 19:46
@kostandinang
kostandinang changed the base branch from ka/fe-1230-greenfield-execution-comparison-tracer to graphite-base/346 July 20, 2026 19:53
@kostandinang
kostandinang force-pushed the ka/fe-1232-comparison-reporting-skills branch from 0cf343b to 59ad59e Compare July 20, 2026 19:53
@kostandinang
kostandinang changed the base branch from graphite-base/346 to ka/fe-1230-greenfield-execution-comparison-tracer July 20, 2026 19:53
Comment thread package.json
@kostandinang
kostandinang changed the base branch from ka/fe-1230-greenfield-execution-comparison-tracer to graphite-base/346 July 20, 2026 19:56
@kostandinang
kostandinang force-pushed the ka/fe-1232-comparison-reporting-skills branch from 59ad59e to 64ffbd7 Compare July 20, 2026 19:56
@kostandinang
kostandinang changed the base branch from graphite-base/346 to ka/fe-1230-greenfield-execution-comparison-tracer July 20, 2026 19:56
@kostandinang
kostandinang changed the base branch from ka/fe-1230-greenfield-execution-comparison-tracer to graphite-base/346 July 20, 2026 20:01
@kostandinang
kostandinang force-pushed the ka/fe-1232-comparison-reporting-skills branch from 64ffbd7 to ae960e3 Compare July 20, 2026 20:01
@kostandinang
kostandinang changed the base branch from graphite-base/346 to ka/fe-1230-greenfield-execution-comparison-tracer July 20, 2026 20:01
@kostandinang
kostandinang changed the base branch from ka/fe-1230-greenfield-execution-comparison-tracer to graphite-base/346 July 20, 2026 20:02

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ae960e3. Configure here.

Comment thread .agents/skills/comparison-reporting/references/execution-comparisons.md Outdated
@kostandinang
kostandinang force-pushed the ka/fe-1232-comparison-reporting-skills branch from ae960e3 to fb61dc3 Compare July 20, 2026 20:17
@kostandinang
kostandinang changed the base branch from graphite-base/346 to next July 20, 2026 20:17
@kostandinang kostandinang self-assigned this Jul 20, 2026
kostandinang and others added 2 commits July 21, 2026 09:55
Give project agents a validity-aware reporting path while keeping Notion mutation and comparison evidence policy separate.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep comparison validity grammar in the comparison skill while limiting the general Notion skill to publication structure, mutation safety, and audience-appropriate evidence handling.

Co-authored-by: Cursor <cursoragent@cursor.com>
kostandinang and others added 3 commits July 21, 2026 09:55
Prevent reporting agents from traversing controller-only case material and keep composed skill-check output honest when a later checker fails.

Co-authored-by: Cursor <cursoragent@cursor.com>
Extend reporting from artifact interpretation into frozen campaign design, reproducible judging, bounded determinism evidence, and requirement-level end-to-end traceability.

Co-authored-by: Cursor <cursoragent@cursor.com>
Satisfy the release-intent gate without versioning the package for project-local skill and documentation changes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kostandinang
kostandinang force-pushed the ka/fe-1232-comparison-reporting-skills branch from f8c17be to 46abd27 Compare July 21, 2026 07:56
kostandinang and others added 3 commits July 21, 2026 09:56
Keep the new Markdown references free of trailing blank-line whitespace so the branch diff passes the repository check.

Co-authored-by: Cursor <cursoragent@cursor.com>
Make active command precedence explicit, redact withheld requirement rows by audience, align repeat defaults with project posture, and verify reporting-skill links recursively.

Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the empty release intent with a patch Changeset for the reporting workflows and evaluation guardrails.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kostandinang
kostandinang merged commit 55f5594 into next Jul 21, 2026
7 checks passed
@kostandinang
kostandinang deleted the ka/fe-1232-comparison-reporting-skills branch July 21, 2026 10:15
@hash-worker hash-worker Bot mentioned this pull request Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant