Skip to content

Fix default table columns for Developer Portal resources - #128

Merged
brandonc merged 3 commits into
mainfrom
WAYP-4193
Sep 22, 2026
Merged

brandonc merged 3 commits into
mainfrom
WAYP-4193

Conversation

@IBeauM

@IBeauM IBeauM commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Description

Jira ticket

  • registry.go: set preferred columns for all four Developer Portal types.
  • jsonapi_test.go: cover column order, rendered values, and missing fields.
  • BUG FIXES-20260922-113109.yaml: document the table display changes.

Example Output

Developer Portal collection tables show the resource ID followed by five preferred fields. Examples below use sample data.

Templates (tdp-templates)

ID             Name      Summary          Module Source   Module ID   Updated At
template-123   web-app   Web application  private         mod-123     2026-01-02T00:00:00Z

Applications (tdp-applications)

ID        Name      Template Name   Tfc Workspace ID   Project   Updated At
app-123   web-app   web-template    ws-123             prj-123   2026-01-02T00:00:00Z

Add-on definitions (tdp-addon-definitions)

ID               Name       Summary     Module Source   Module ID   Updated At
definition-123   database   Shared DB   private         mod-456     2026-01-02T00:00:00Z

Add-ons (tdp-addons)

ID          Name           Definition.Name   Terraform Workspace ID   Application.ID   Updated At
addon-123   app-database   postgres          ws-456                   app-123          2026-01-02T00:00:00Z

PR Checklist

  • Run npx changie new or install changie to prepare a new changelog entry for the next set of release notes.
  • Ensure any command changes are sensitive to these global flags:
    • --json — Force machine readable output to stdout. Does not apply to stderr.
    • --markdown — Force markdown output to stdout. Does not apply to stderr.
    • --dry-run — Don't make any actual writes or other mutations. Describe what would have changed to stderr.
    • --quiet — Only render essential content.
  • [NA] Get the logging interface from the context and add debug logging for interesting conditions and nonfatal situations.
  • [NA] Run make gen/screenshot if the root command output changes.
  • [NA] Add the Autocomplete field to positional arguments and flags to assist shell autocomplete.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • [NA] If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • [NA] If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

- registry.go: set preferred columns for all four Developer Portal types.
- jsonapi_test.go: cover column order, rendered values, and missing fields.
- BUG FIXES-20260922-113109.yaml: document the table display changes.
@IBeauM IBeauM self-assigned this Sep 22, 2026
@hashicorp-cla-app

hashicorp-cla-app Bot commented Sep 22, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@IBeauM
IBeauM marked this pull request as ready for review September 22, 2026 17:51

@brandonc brandonc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one minor changelog suggestion. Might be easiest to rm the changelog file and start over with changie new

@@ -0,0 +1,3 @@
kind: BUG FIXES
body: Show names and key fields in Developer Portal template, application, add-on definition, and add-on collection tables.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the kind to ENHANCEMENTS and reword "Improve table rendering for developer portal resources"
?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks

@brandonc
brandonc merged commit 306e370 into main Sep 22, 2026
3 checks passed
@brandonc
brandonc deleted the WAYP-4193 branch September 22, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants