Conversation
- registry.go: set preferred columns for all four Developer Portal types. - jsonapi_test.go: cover column order, rendered values, and missing fields. - BUG FIXES-20260922-113109.yaml: document the table display changes.
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
IBeauM
marked this pull request as ready for review
September 22, 2026 17:51
brandonc
reviewed
Sep 22, 2026
brandonc
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Just one minor changelog suggestion. Might be easiest to rm the changelog file and start over with changie new
| @@ -0,0 +1,3 @@ | |||
| kind: BUG FIXES | |||
| body: Show names and key fields in Developer Portal template, application, add-on definition, and add-on collection tables. | |||
Collaborator
There was a problem hiding this comment.
Can you change the kind to ENHANCEMENTS and reword "Improve table rendering for developer portal resources"
?
brandonc
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira ticket
Example Output
Developer Portal collection tables show the resource ID followed by five preferred fields. Examples below use sample data.
Templates (
tdp-templates)Applications (
tdp-applications)Add-on definitions (
tdp-addon-definitions)Add-ons (
tdp-addons)PR Checklist
npx changie newor install changie to prepare a new changelog entry for the next set of release notes.--json— Force machine readable output to stdout. Does not apply to stderr.--markdown— Force markdown output to stdout. Does not apply to stderr.--dry-run— Don't make any actual writes or other mutations. Describe what would have changed to stderr.--quiet— Only render essential content.make gen/screenshotif the root command output changes.Autocompletefield to positional arguments and flags to assist shell autocomplete.PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
[NA] If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
[NA] If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.