feat: [CLI-56856]: Add configurable request timeout by dtsong-harness · Pull Request #94 · harness/harness-cli

dtsong-harness · 2026-04-09T21:14:05Z

Summary

Adds a --timeout global flag (default: no timeout) to configure the HTTP request timeout for API calls
Supports HARNESS_TIMEOUT_SECONDS environment variable as an alternative to the flag
Replaces hardcoded 10-second timeout in util/client/iacm/iacm-client.go

Motivation

The 10-second hardcoded timeout causes failures for API calls that legitimately take longer (e.g., large account queries, migration jobs, slow network conditions). Users currently have no way to increase this without switching to raw curl calls.

By defaulting to no timeout (0), long-running commands like migrations work out of the box, while users can set a timeout if desired.

Usage

# Via flag (set 30-second timeout)
hc iacm plan --timeout 30 --org myorg --project myproject --workspace myworkspace

# Via environment variable
export HARNESS_TIMEOUT_SECONDS=30
hc iacm plan --org myorg --project myproject --workspace myworkspace

# Default behavior: no timeout
hc iacm plan --org myorg --project myproject --workspace myworkspace

Changes

File	Change
`config/globals.go`	Added `TimeoutSeconds` field and `DefaultTimeoutSeconds` constant (default: 0)
`cmd/hc/main.go`	Registered `--timeout` persistent flag, `HARNESS_TIMEOUT_SECONDS` env var, and input validation
`util/client/iacm/iacm-client.go`	Uses configurable timeout instead of hardcoded 10s

Test plan

go build ./cmd/hc/ compiles successfully
go test ./... — all existing tests pass
hc --help shows --timeout flag with "default: no timeout"
Manual: hc --timeout 30 iacm plan ... uses 30s timeout
Manual: HARNESS_TIMEOUT_SECONDS=30 hc iacm plan ... uses 30s timeout
Manual: negative timeout value is rejected with error

🤖 Generated with Claude Code

…_TIMEOUT env var The HTTP request timeout was hardcoded to 10 seconds across the CLI, causing failures for API calls that legitimately take longer. This adds a --timeout global flag (default 10s) and HARNESS_TIMEOUT environment variable so users can increase the timeout as needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

CLAassistant · 2026-04-09T21:14:15Z

All committers have signed the CLA.

- Rename env var from HARNESS_TIMEOUT to HARNESS_TIMEOUT_SECONDS for clarity - Error and exit on invalid HARNESS_TIMEOUT_SECONDS value instead of silently ignoring - Remove redundant default in GlobalFlags struct (already set via flag default in main.go) - Revert login.go to hardcoded 10s timeout since it's a one-off client Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jliu-harness · 2026-04-09T23:41:22Z

 		config.Global.ProjectID = envVal
 	}
+	if envVal := os.Getenv("HARNESS_TIMEOUT_SECONDS"); envVal != "" {
+		timeout, err := strconv.Atoi(envVal)


This is user input. So a sanity check on the value range may be useful. timeout should be within a range, maybe [0, 3600]? I don't think the server will have a timeout of 1 hour.

Validates --timeout flag and HARNESS_TIMEOUT_SECONDS are within [0, 3600] to prevent unreasonable timeout values from user input. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove max timeout cap and default to 0 (no timeout) since long-running commands like migrations need unbounded time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>