Skip to content

Add Makefile and make npm install use it #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
khaledhosny merged 1 commit into from
Jan 24, 2026
Merged

Add Makefile and make npm install use it #148

khaledhosny merged 1 commit into from
Jan 24, 2026

Conversation

@khaledhosny
Copy link
Contributor

@khaledhosny khaledhosny commented Jan 24, 2026

Remove the old build scripts.

@khaledhosny
Add Makefile and make npm install use it
be0ca16 
Remove the old build scripts.
@khaledhosny khaledhosny merged commit 33e811c into main Jan 24, 2026
2 checks passed
@khaledhosny khaledhosny deleted the make-file branch January 24, 2026 18:46
@justvanrossum
Copy link

justvanrossum commented Jan 26, 2026

I think the README needs updating for this change:

harfbuzzjs/README.md

Lines 16 to 18 in f52db21

## Building
1. Install emscripten
2. `./build.sh`

@khaledhosny
Copy link
Contributor Author

khaledhosny commented Jan 26, 2026

Thanks, I updated it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khaledhosny @justvanrossum