fix: "Should not already be working" in Firefox after a breakpoint/alert#1
Open
han89092277 wants to merge 1 commit intomainfrom
Open
fix: "Should not already be working" in Firefox after a breakpoint/alert#1han89092277 wants to merge 1 commit intomainfrom
han89092277 wants to merge 1 commit intomainfrom
Conversation
…17355) When stepping through code in devtools or when an alert causes re-entrancy in older browsers, instead of throwing 'Should not already be working', it now logs an error and bails out to prevent app crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where "Should not already be working" error fires inappropriately in certain browsers (Chrome 68, Firefox) during event-loop-interrupting events like breakpoints or alerts.
Changes
throw new Errorwith aconsole.errorand an earlyreturninperformWorkOnRootandcommitRootImplto gracefully bail out instead of crashing the app.Testing
Verified via manual trace of the error condition.
Fixes facebook#17355