Move vectorize_pred to test/correctness, fix failing_with_issue build#9112
Open
kjg0724 wants to merge 1 commit intohalide:mainfrom
Open
Move vectorize_pred to test/correctness, fix failing_with_issue build#9112kjg0724 wants to merge 1 commit intohalide:mainfrom
kjg0724 wants to merge 1 commit intohalide:mainfrom
Conversation
Issue halide#3357 now passes. Rewrote the test to initialize f/g with cast<A>(0) rather than undef so all positions are deterministic and the full output is compared. Widened to W = vec_width * 4, H = 1000 to cover more predicate-edge conditions. Update 3292 and 3293 to the current JITUserContext* allocator API (set_custom_allocator was removed). Add EXPECT_FAILURE so ctest treats the still-crashing tests as known failures. Comment out 4283 whose source file does not exist. Enable add_subdirectory(failing_with_issue) in test/CMakeLists.txt.
kjg0724
force-pushed
the
fix/failing-with-issue-phase1
branch
from
5e40b9c to
ebfa487
Compare
Author
|
Updated: gate failing_with_issue behind WITH_TEST_FAILING_WITH_ISSUE=OFF (consistent with other test dirs), delete orphaned 3357_vectorize_pred.cpp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3357 now passes. Rewrote vectorize_pred to initialize f/g with
cast(0) so all positions are deterministic and the full output is
compared. Widened to W = vec_width * 4, H = 1000.
Update 3292/3293 allocator callbacks to JITUserContext* (the old
void* user_context and set_custom_allocator() API was removed).
Add EXPECT_FAILURE so ctest treats the still-crashing tests as known
failures. Comment out 4283 (no source file in tree). Enable
add_subdirectory(failing_with_issue).