Document the usage of release types#206
Open
jonatan-ivanov wants to merge 1 commit intohalcyon:masterfrom
Open
Document the usage of release types#206jonatan-ivanov wants to merge 1 commit intohalcyon:masterfrom
jonatan-ivanov wants to merge 1 commit intohalcyon:masterfrom
Conversation
Since halcyongh-179 users can set java_release_type and choose if they want support for GA/EA/both builds. See halcyongh-179
Contributor
Author
|
The build is failing but I think the failure is unrelated to my changes. |
|
Looks good to me! |
|
Oh, it seems something has changed. Instead of /tmp/asdf-java.cache, the cache directory is now at /tmp/asdf-java-${USER}.cache. That led to some confusion! Ideally, i think the java_release_type would go into the cache path somewhere, perhaps in the name of the actual cache file. Then, if you change the release type, you wouldn't have to remember to purge the cache. |
Contributor
Author
|
@halcyon Could you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since gh-179, users can set java_release_type and choose if they want support for GA/EA/both builds.
See gh-179