Repository navigation
feat: add and complete Identifiers.java for HasIdentifier contract with dave - #432
Merged
Merged
Conversation
Centralizes static identifiers used by HasIdentifier components into a single file, mirroring the OuiaIds.java pattern for OUIA IDs. These identifiers are synced to dave via pnpm sync:identifiers and serve as the contract for [data-identifier="..."] selectors. Includes: - 20 static constants (columns, finder items, breadcrumb, tasks) - build() method for dynamic identifiers (mirrors Id.build()) - fromTemplate() for address template-based identifiers All configuration column and finder item classes updated to reference Identifiers constants instead of local string literals. Closes #428 (partial)
…mplate() Single source of truth for the template-to-identifier conversion logic. AddressTemplate now delegates to Identifiers.fromTemplate() instead of duplicating the replacement and Id.build() call.
5 tasks
…ts (#433) Audit all PFJ HasIdentifier component usages across halOP and centralize static identifiers in Identifiers.java (20 → 62 constants). Update 18 source files to reference Identifiers.* instead of string literals. Document dynamic identifier conventions in Javadoc.
hpehl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Identifiers.javawith 62 static constants covering allHasIdentifierusages across halOPAddressTemplate.identifier()toIdentifiers.fromTemplate()Identifiers.*instead of string literalsAudit coverage
All PFJ components implementing
HasIdentifierthat are used in halOP were traced and classified:Identifiers.javaTest plan
mvn compile -P op -Dquicklybuilds successfullymvn test -P op -Dquicklyall tests passpnpm sync:identifiersin dave picks up all 62 constantsCloses #433