Repository navigation
Conversation
Added dynamic OUIA IDs: - FinderBricks.crudColumn(): hal-op-<column-id> on all CRUD columns - ConfigurationColumn: hal-op-configuration-column + item IDs (subsystems-item, interfaces-item, socket-bindings-item, paths-item, system-properties-item) - SubsystemColumn: hal-op-subsystem-column The crudColumn() change automatically covers all columns using this helper: SystemPropertyColumn, InterfaceColumn, PathColumn, SocketBindingGroupColumn, InboundColumn, OutboundLocalColumn, OutboundRemoteColumn, and socket binding sub-columns. Closes #428 (partial)
Replace plain string literals with package-private constants for the 5 finder item identifiers used in both finderItem() and ouiaId() calls.
Member
Author
|
Closing — finder columns and items implement HasIdentifier, so they are locatable via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds dynamic OUIA IDs to finder columns and items in the configuration feature. Part of #428.
Changes
FinderBricks.crudColumn()— adds.ouiaId(OuiaIds.ouia(id))on every CRUD column, automatically covering:SystemPropertyColumn→hal-op-system-property-columnInterfaceColumn→hal-op-interface-columnPathColumn→hal-op-path-columnSocketBindingGroupColumn→hal-op-socket-binding-group-columnConfigurationColumn— OUIA IDs on the column and its 5 finder items:hal-op-configuration-columnhal-op-subsystems-item,hal-op-interfaces-item,hal-op-socket-bindings-item,hal-op-paths-item,hal-op-system-properties-itemSubsystemColumn— OUIA ID on the column:hal-op-subsystem-columnModified Files
ui/.../finder/FinderBricks.java—.ouiaId()incrudColumn()helperop/console/.../configuration/ConfigurationColumn.java— constants +.ouiaId()on column and itemsop/console/.../configuration/SubsystemColumn.java—.ouiaId()on columnTesting
./mvnw compile -P oppassespnpm sync:ouia)