Repository navigation
feat: add OUIA IDs for shared UI components and skeleton toolbar - #429
Merged
Merged
Conversation
Added static constants: - ENDPOINT_SELECTOR - MODEL_GRAPH_INDICATOR - NOTIFICATION_BADGE - SEARCH_BTN - THEME_SELECTOR Added dynamic OUIA IDs: - ResourceList: hal-op-resource-list-<child-type> - DefaultFormItem: hal-op-form-item-<attribute-name> These IDs enable dave (halOP test suite) to target skeleton toolbar items, resource lists, and form fields with stable OUIA selectors. Closes #428 (partial)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds OUIA IDs to shared UI components and skeleton toolbar items so they can be targeted by dave tests. Part of #428.
New Static Constants in OuiaIds.java
ENDPOINT_SELECTORhal-op-endpoint-selectorMODEL_GRAPH_INDICATORhal-op-model-graph-indicatorNOTIFICATION_BADGEhal-op-notification-badgeSEARCH_BTNhal-op-search-btnTHEME_SELECTORhal-op-theme-selectorDynamic OUIA IDs
hal-op-resource-list-<child-type>(e.g.hal-op-resource-list-data-source)hal-op-form-item-<attribute-name>(e.g.hal-op-form-item-port)Modified Files
resources/.../OuiaIds.java— 5 new constantsop/console/.../skeleton/Skeleton.java—.ouiaId()on search button, notification badge, theme selector, model graph indicator, endpoint selectorui/.../resource/shell/ResourceList.java— dynamic OUIA ID based on template child typeui/.../resource/form/DefaultFormItem.java— dynamic OUIA ID based on attribute identifierTesting
./mvnw compile -P oppassespnpm sync:ouia)