Modify wins.js to accept GitHub and LinkedIn usernames and construct URLs#8613
Modify wins.js to accept GitHub and LinkedIn usernames and construct URLs#8613lc1715 wants to merge 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 6PM 4/24/2026 |
|
Review ETA: EOD 4/22/2026 |
There was a problem hiding this comment.
Hi Lisa,
Nice work on this. Using the GitHub Handle and LinkedIn Name properties to construct the URL values in the main function keeps the code simple and avoids duplicating conditional logic at the point of use. That made the implementation feel really clean and easy to follow.
I tested this by updating a few entries in _wins-data.json with GitHub Handle and LinkedIn Name values, and confirmed that the URLs are constructed correctly when the original URL fields are empty.
I was curious how you tested this on your end since the changes aren't directly visible in the UI and rely on data in the JSON file. I'd be interested to hear your approach there.
No changes requested from my side, happy to approve.
|
Hi Jose! Yes, I also tested this by updating the |
|
Awesome, sounds like we're on the same page. Nice work Lisa! |
|
Thanks! |
Fixes #5470
What changes did you make?
Github URL (optional)andLinkedin URL (optional)are blank, the code will reference the new fieldsGitHub HandleandLinkedIn Nameand will construct the appropriate URLs.Why did you make the changes (we will use this info to test)?
GitHub HandleandLinkedIn Nameand reconstruct the appropriate URLs.CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)