Skip to content

feat: project cards #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: project cards #31

wants to merge 7 commits into from

Conversation

@cyteon
Copy link
Member

@cyteon cyteon commented Oct 20, 2025 •
edited
Loading

image

@cyteon cyteon requested a review from cskartikey October 20, 2025 15:54
@cyteon cyteon added the enhancement New feature or request label Oct 20, 2025
@r58Playz
Copy link
Member

r58Playz commented Oct 20, 2025

The SVGs should probably become actual SVGs with a black/white/currentColor fill/stroke, some of them are actually base64'd PNGs

@cyteon
Copy link
Member Author

cyteon commented Oct 20, 2025

i just copied them from figma

@cskartikey
Copy link
Member

cskartikey commented Oct 21, 2025

can you replace these w/ actual SVGs? Find comparable assets. Plus, it'd be great if this was a separate css class so anyone can add this!

@cskartikey
Copy link
Member

cskartikey commented Oct 21, 2025

there are already assets in app/assets/images/mask – use that?

@cyteon
Copy link
Member Author

cyteon commented Oct 21, 2025

Sure, ill switch to those

@cyteon
Copy link
Member Author

cyteon commented Oct 21, 2025

But wdym make it a seperate css class?

@cyteon
Copy link
Member Author

cyteon commented Oct 21, 2025

Changed to the assets that were already there, but they are in png rn.
Should i convert them to svg?

@cyteon
Copy link
Member Author

cyteon commented Oct 21, 2025

Changed the pan svg to not contain a image, and just be svg

@cskartikey
Copy link
Member

cskartikey commented Oct 21, 2025

But wdym make it a seperate css class?
like a css class? i want to be able to add this to any element and get that effect

@cyteon
Copy link
Member Author

cyteon commented Oct 21, 2025 •
edited
Loading

ah, which effect exactly? the icons on the background of the card?

3kh0
3kh0 requested changes Nov 5, 2025
View reviewed changes
Copy link
Member

@3kh0 3kh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts present

@cskartikey cskartikey force-pushed the main branch 3 times, most recently from 4028660 to 22558e2 Compare November 6, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3kh0 3kh0 3kh0 requested changes

@cskartikey cskartikey Awaiting requested review from cskartikey

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyteon @r58Playz @cskartikey @3kh0