Feature/11 api postgres by Lightsul · Pull Request #43 · hack4impact/moisson-project

Lightsul · 2026-10-28T17:42:34Z

Closes #11

Overview

Base de l'API centrale et connexion à PostgreSQL.

Retrait du template WeatherForecast
MoissonDbContext (vide pour l'instant, le schéma viendra avec son issue)
Chaîne de connexion lue depuis la configuration : user-secrets en local, variable d'environnement ConnectionStrings__Moisson` sinon. L'API refuse de démarrer si elle est absente.
Endpoint /health qui vérifie la connexion à la base (Healthy 200 / Unhealthy 503)
Correction d'un conflit de versions d'EF Core entre Api et Tests
Tests d'intégration de /health (WebApplicationFactory + Testcontainers)

Tests automatisés

dotnet test` : 3/3 réussis (Docker requis pour Testcontainers)
tests/MoissonMontreal.Tests/Api/HealthEndpointTests.cs

Checklist

- Retire le template WeatherForecast (contrôleur, modèle, requête .http) - Ajoute MoissonDbContext dans Data/ et l'enregistre avec Npgsql - Lit ConnectionStrings:Moisson depuis la configuration (user-secrets en local, variables d'environnement sinon) ; l'API refuse de démarrer si la chaîne est absente - Fixe Microsoft.EntityFrameworkCore.Relational en 10.0.13 pour régler le conflit de versions d'EF Core dans Tests

- Ajoute le package HealthChecks.EntityFrameworkCore 10.0.13 - Expose /health : Healthy (200) si PostgreSQL répond, Unhealthy (503) sinon - Rend le message d'erreur de connexion autonome (commande user-secrets incluse)

- WebApplicationFactory pour démarrer l'API en mémoire - Testcontainers pour une base PostgreSQL 17 jetable - Vérifie Healthy (200) quand la base répond et Unhealthy (503) quand elle est injoignable

lauriechammah · 2026-10-28T19:07:02Z

      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>
+    <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="10.0.13" />


Microsoft.EntityFrameworkCore.Relational 10.0.13 is already provided by Npgsql

Suggested change

<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="10.0.13" />

Bien vu, merci ! Je l'avais ajouté pour régler un conflit de versions EF Core (10.0.4 vs 10.0.13) dans le projet Tests, mais depuis l'ajout de HealthChecks.EntityFrameworkCore 10.0.13 il est redondant.

lauriechammah · 2026-10-28T19:09:18Z

@@ -20,4 +34,6 @@

 app.MapControllers();

+app.MapHealthChecks("/health");


MVC configuration is currently pointless, but we will most likely add controllers soon. We can keep them for now

lauriechammah · 2026-10-28T19:10:18Z

+        "La chaîne de connexion 'Moisson' est absente. Définissez ConnectionStrings__Moisson " +
+        "ou utilisez 'dotnet user-secrets'. ");


Remove space at the end of error message

Suggested change

"La chaîne de connexion 'Moisson' est absente. Définissez ConnectionStrings__Moisson " +

"ou utilisez 'dotnet user-secrets'. ");

"La chaîne de connexion 'Moisson' est absente. Définissez ConnectionStrings__Moisson " +

"ou utilisez 'dotnet user-secrets'.");

- Déjà fournie en 10.0.13 via HealthChecks.EntityFrameworkCore - Retire un espace en trop dans le message d'erreur de connexion

lauriechammah

Overall good. For the future, make sure that your PR and commit messages are written in English.

Please fix the issues I have mentioned in my comments. Thank you! :)

lauriechammah · 2026-10-28T19:13:24Z

+
 var builder = WebApplication.CreateBuilder(args);

+var connectionString = builder.Configuration.GetConnectionString("Moisson")


Cloning the repo causes a crash on dotnet run: ConnectionStrings:Moisson isn't defined anywhere, even though compose.yaml already sets the dev credentials. Could we add the local dev connection string to appsettings.Development.json?

"ConnectionStrings": { "Moisson": "Host=localhost;Port=5432;Database=moisson_dev;Username=moisson;Password=moisson" }

These are local-only Docker credentials, so committing them is fine. User-secrets/env vars can still override them.

lauriechammah · 2026-10-28T19:13:24Z

+
+
 // Add services to the container.
+builder.Services.AddDbContext<MoissonDbContext>(options => options.UseNpgsql(connectionString));


Heads-up for the migrations issue: because the connection string is read and validated at startup (line 7), dotnet ef migrations add will throw on any machine/CI without the secret, since EF runs Program to build the DbContext. Fixing the dev config (comment above) mostly solves it. Otherwise, add an IDesignTimeDbContextFactory.

lauriechammah · 2026-10-28T19:13:24Z


 app.MapControllers();

+app.MapHealthChecks("/health");


/health sits behind UseHttpsRedirection(), so an HTTP health probe (Docker, Kubernetes, load balancer) gets a 307 instead of the status and may mark the service as down. Not a problem today, but worth keeping in mind when we deploy (e.g. skip the redirect for /health).

lauriechammah · 2026-10-28T19:13:24Z

+
+public class HealthEndpointTests : IAsyncLifetime
+{
+    private readonly PostgreSqlContainer _postgres = new PostgreSqlBuilder("postgres:17").Build();


xUnit creates a new instance of the class per test, so this starts a new Postgres container for each test (including the "unreachable" one, which doesn't use it). Moving the container into a shared IClassFixture<PostgresFixture> would start it only once and speed up the suite.

lauriechammah · 2026-10-28T19:13:24Z

+
+namespace MoissonMontreal.Tests.Api;
+
+public class HealthEndpointTests : IAsyncLifetime


These tests require Docker to be running, otherwise dotnet test fails with DockerUnavailableException. Could we tag them (e.g. [Trait("Category", "Integration")]) so they can be filtered, and mention the Docker requirement in the README?

lauriechammah · 2026-10-28T19:13:24Z

+    public async Task Health_RetourneUnhealthy_QuandLaBaseEstInjoignable()
+    {
+        // Rien n'écoute sur le port 1 : la connexion échoue immédiatement.
+        await using var factory = CreerFactory("Host=localhost;Port=1;Database=inexistante;Username=test;Timeout=2");


Minor: localhost can resolve to both ::1 and 127.0.0.1, and some CI firewalls drop packets instead of refusing them, so this can wait for the timeout twice instead of failing immediately. Using Host=127.0.0.1 makes it more predictable.

anis022

@lauriechammah requested changes cover pretty much everything that needs to be addressed. Other than that, looks good to me. Great work.

Lightsul added 4 commits October 28, 2026 00:02

test(api): ajouter les tests d'intégration de l'endpoint /health

0059579

- WebApplicationFactory pour démarrer l'API en mémoire - Testcontainers pour une base PostgreSQL 17 jetable - Vérifie Healthy (200) quand la base répond et Unhealthy (503) quand elle est injoignable

fix(api): retirer le renvoi au README du message d'erreur de connexion

b8e802b

Lightsul self-assigned this Oct 28, 2026

Lightsul added the back-end label Oct 28, 2026

Lightsul added this to the Sprint - 1 milestone Oct 28, 2026

Lightsul linked an issue Oct 28, 2026 that may be closed by this pull request

[Issue]: Central ASP.NET Core API with PostgreSQL connection #11

Open

4 of 7 tasks

Lightsul requested review from anis022 and lauriechammah October 28, 2026 17:52

lauriechammah reviewed Oct 28, 2026

View reviewed changes

chore(api): retirer la référence redondante à EF Core Relational

d606f29

- Déjà fournie en 10.0.13 via HealthChecks.EntityFrameworkCore - Retire un espace en trop dans le message d'erreur de connexion

lauriechammah requested changes Oct 28, 2026

View reviewed changes

anis022 requested review from anis022 and removed request for anis022 October 28, 2026 19:46

anis022 approved these changes Oct 28, 2026

View reviewed changes

anis022 requested review from MarcAntoineGmd and removed request for MarcAntoineGmd October 28, 2026 20:00

maayjayy mentioned this pull request Oct 29, 2026

Feature/01 black on white #46

Open

6 tasks done

Navigation Menu

Repository navigation

Feature/11 api postgres - #43

Feature/11 api postgres#43
Lightsul wants to merge 5 commits into
developfrom
feature/11-api-postgres

Lightsul commented Oct 28, 2026 •

edited

Loading

Uh oh!

lauriechammah Oct 28, 2026

Uh oh!

Lightsul Oct 28, 2026

Uh oh!

lauriechammah Oct 28, 2026

Uh oh!

lauriechammah Oct 28, 2026

Uh oh!

lauriechammah left a comment

Uh oh!

lauriechammah Oct 28, 2026

Uh oh!

lauriechammah Oct 28, 2026

Uh oh!

lauriechammah Oct 28, 2026

Uh oh!

lauriechammah Oct 28, 2026

Uh oh!

lauriechammah Oct 28, 2026

Uh oh!

lauriechammah Oct 28, 2026

Uh oh!

anis022 left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="10.0.13" />

		@@ -20,4 +34,6 @@

		app.MapControllers();

		app.MapHealthChecks("/health");

		"La chaîne de connexion 'Moisson' est absente. Définissez ConnectionStrings__Moisson " +
		"ou utilisez 'dotnet user-secrets'. ");


		var builder = WebApplication.CreateBuilder(args);

		var connectionString = builder.Configuration.GetConnectionString("Moisson")



		// Add services to the container.
		builder.Services.AddDbContext<MoissonDbContext>(options => options.UseNpgsql(connectionString));


		namespace MoissonMontreal.Tests.Api;

		public class HealthEndpointTests : IAsyncLifetime

Conversation

Lightsul commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Tests automatisés

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lauriechammah left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anis022 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lightsul commented Oct 28, 2026 •

edited

Loading