Repository navigation
Conversation
…reap failed relay starts HACK-1342 items 2 and 4 (item 1 is already fixed on next by #399; item 3 is left to #419). Item 2: the relay refuses an excess connection (and one whose target is down) by accepting and closing it, which can happen before the client's next syscall. Once the peer has closed, macOS rejects SO_RCVTIMEO and SO_SNDTIMEO with EINVAL, so `Relay::connect` panicked at the `set_read_timeout`/`set_write_timeout` unwraps. The relay is correct. The two refusal tests now use `Relay::connect_refused`, which sets no socket timeouts: it waits for readability with a bounded poll and then still requires EOF or a reset. A live peer or a peer that sends data still fails the check. Item 4: `Relay::start_options` now hands the spawned child to the existing `PublisherStartup` guard until readiness is proven, so a failed or panicking readiness check kills and reaps `stream-relay-host` (and removes a fresh root) instead of orphaning it. Refs HACK-1342 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ID (HACK-1342) Relay test roots were named /tmp/<prefix>-<pid>-<n> and created with create_dir().unwrap(), so a directory left by an earlier run whose PID is now reused failed a fresh test with EEXIST. fresh_root() skips an existing name, and every root site uses it, including the fixed-name ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration gate for merge batch b65: origin/next + #508 (HACK-1342). Tree 7f93f4ab. Closed after the batch squashes.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.