Repository navigation
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd4422788c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
roodboi
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a36c1156d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Updated head: 3318bd6. The environment-root precedence finding is fixed, and regression coverage now explicitly proves that an ordinary checkout keeps one stable repository store despite its worktree-prefixed execution identity, including after adding a remote and linked checkout. Full isolated suite: 1,184 passed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3318bd60f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const canonicalRoot = canonicalProjectAiRoot(rootDir, home, config); | ||
| const repositoryKey = repositoryKeyForCanonicalRoot( | ||
| canonicalRoot, | ||
| home, | ||
| config |
There was a problem hiding this comment.
When a primary and linked checkout both have project-render inputs, rendering in one now prevents rendering in the other. src/project-render-apply.ts derives its default receipt directory from facultMachineStateDir(home, canonicalRoot), so this change makes both checkouts share project-render/receipt.json. However, projectId() still hashes the real checkout path, and applyProjectRender() rejects the second checkout with “Project render ownership receipt belongs to a different project.” The CLI passes the explicit --root and --project-root through without redirecting them, so this affects normal project render invocations, not just internal callers. Keep checkout-bound render receipts and transactions execution-scoped while sharing the durable loop store.
Useful? React with 👍 / 👎.
Linked worktree loop invocations previously selected execution-keyed runtime directories, producing separate
worktree_*stores and automation names.Resolve enrollment and loop commands through the shared Git common directory, verify the linked-worktree registration and primary checkout, and use canonical configuration and repository state. Existing canonical slug stores remain readable. Prior nonempty primary-checkout execution stores now block with a reconciliation message instead of silently losing access to queues, configuration, automations, and history. Shared indexes and graphs also scan canonical assets. Historical worktree stores are retained. Ordinary checkouts retain a stable repository store even though their receipt/execution identity also starts with
worktree_; only linked checkout paths redirect to the primary checkout. Environment-selected roots and explicit CLI root/scope precedence remain intact.Add
fclt ai loop status --all-projects --stale-after 8d --json: a read-only report of scheduler status,lastRunAt,lastSuccessfulScheduledRunAt, staleness, andephemerallegacy stores. That flag identifies the legacy execution-key format; older primary-checkout stores can also have it, so it is not evidence that their data is disposable. Missing, invalid, future, and older run timestamps are stale; recent execution remains distinct from successful scheduled coverage.Validation:
bun run checkandbun run type-checkbun run pack:dry-run, privacy review, andgit diff --checkPost-merge activation plan:
fclt ai loop enable --projectto re-enable/unpause the intended per-project automation. Leave historical ephemeral stores and automations untouched pending separate review.fclt ai loop status --all-projects --stale-after 8d --jsonand verify every real project's canonical store haslastRunAtwithin eight days. Account for legacyworktree_*rows during reconciliation rather than assuming they are disposable. Check scheduler status and successful scheduled timestamps separately.No live automations or runtime stores were changed during this work. Scheduling activation remains a post-merge operation.