Repository navigation
Conversation
|
@codex review Please review malformed writeback array handling, warning deduplication, and preservation of valid-entry assessment. Regression coverage is in the new |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fclt ai evolve assess --jsoncrashed when a persisted writeback had no evidence array. Missing or non-array evidence now counts as empty, malformed entries produce an ID-bearing warning on stderr, and assessment JSON includes awarningslist. Good entries continue through assessment.The shared loader also normalizes tags and issue links for sibling commands. The independent reconciliation reader uses the same normalization. Assessment leaves persisted queues unchanged, and repeated reads within one CLI invocation emit one warning per entry ID.
The malformed-entry tests live in the new
src/ai-evolve-malformed.test.tssuite. The existing AI CLI and reconciliation test files are unchanged.Validation used fully isolated HOME and all four XDG directories, plus local quarantine-cleanup preloads:
./scripts/test-safe.sh src/ai-evolve-malformed.test.ts: 12 passed../scripts/test-safe.sh src/reconciliation.test.ts --test-name-pattern writeback: 8 passed.3ad4959.bun run type-check,bun run check, andgit diff --check: passed.Risks: assessment JSON gains an additive warnings field. This handles missing/non-array fields; it preserves existing validation of array members. CI and review are pending.
Claude (Fable 5.1) review pending until Oct 30 rate limit; Codex review requested
Need help on this PR? Tag
@codesmith-botwith what you need.