cut at new layout logic for LinearLayout #614
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I think it would be fairly easy to update this logic to add weight support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix Bug #613
In theory, this code could be placed inside the
desperationbranch wherecapis called. To fix the bug, you have to do most of the work that layout does, so it's here as a replacement for the layout code.I wouldn't take this PR as is. I am not that familiar w/ cursive, nor rust. It likely needs some tweaking for both.
I think the algorithm is sound and generates similar (but different) results as the previous algorithm (plus bug fix). I personally think it's simpler? but that might be just because I wrote it.
If there is another / better / simpler way to address the bug in question, I'd be happy to take a stab at that w/ some guidance.