Fix AOB scan bounds and expose main-image ambiguity detection - #16
Draft
Krarilotus wants to merge 3 commits into
Draft
Krarilotus wants to merge 3 commits into
Krarilotus wants to merge 3 commits into
Conversation
Krarilotus
marked this pull request as draft
September 12, 2026 19:30
This was referenced Sep 12, 2026
Owner
|
When did you encounter said bugs? Do you have some reproducible code that causes the bug? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: On hold as a combined proposal: fix scan-range bugs and add an optional unique-match search API.
The existing scan can exceed bounds and skip final-position matches. Those are concrete bugs. Searching executable pages for two matches is an additional capability whose consumer requirement was withdrawn.
Changes: Clip readable ranges and fix short/end cases in the existing scanner. The draft also adds
scanForAOBInMainModuleand a package-version update.Review / testing: Separate the range correction from the API expansion for review. The old scanner fails the native upper-bound regression; Debug/Release and boundary checks passed for the draft. Hotkeys/Recorder no longer require the added API. The author’s hold on new framework APIs still applies.
Fixes #15. Native regression run.