chore: remove double-quote-string-fixer - #136
Conversation
double-quote-string-fixer forces single quotes while ruff-format forces double quotes. Both hooks rewrite the same files, so pre-commit reports "files were modified by this hook" and no committed state satisfies both.
|
Up to standards ✅🟢 Issues
|
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Single-line deletion of the Files Reviewed (1 files)
Notes: no inline comments posted. Findings outside the changed (deleted) line were not anchored to nearby context lines. Reviewed by free · Input: 36.7K · Output: 1.8K · Cached: 97.5K |



Summary
Remove the
double-quote-string-fixerhook from.pre-commit-config.yaml.double-quote-string-fixerrewrites"x"to'x', whileruff-formatin thissame config rewrites
'x'back to"x". Both hooks modify the same files, sopre-commit fails with
files were modified by this hookand no committedstate can satisfy both — the check fails on every run, on any Python file.
This repository currently has no Python files, so the conflict is latent rather
than active. It becomes an immediate failure in any repo that does contain
Python code.
ruff-formatis retained as the sole owner of quote style. It is a superset ofthe removed hook and stays configurable via
[tool.ruff.format]if singlequotes are ever preferred.
No source files are changed: the hook currently passes in every repo that has
Python code, so all existing code is already single-quoted and removing the
enforcement is a no-op.
Validation
pre-commit run --all-filesexits 0 with no hook modifying any fileorigin/masterChecklist