Skip to content

chore: remove double-quote-string-fixer - #136

Merged
gvatsal60 merged 1 commit into
masterfrom
chore/remove-double-quote-string-fixer
Oct 4, 2026
Merged

gvatsal60 merged 1 commit into
masterfrom
chore/remove-double-quote-string-fixer

Conversation

@gvatsal60

Copy link
Copy Markdown
Owner

Summary

Remove the double-quote-string-fixer hook from .pre-commit-config.yaml.

double-quote-string-fixer rewrites "x" to 'x', while ruff-format in this
same config rewrites 'x' back to "x". Both hooks modify the same files, so
pre-commit fails with files were modified by this hook and no committed
state can satisfy both
— the check fails on every run, on any Python file.

This repository currently has no Python files, so the conflict is latent rather
than active. It becomes an immediate failure in any repo that does contain
Python code.

ruff-format is retained as the sole owner of quote style. It is a superset of
the removed hook and stays configurable via [tool.ruff.format] if single
quotes are ever preferred.

No source files are changed: the hook currently passes in every repo that has
Python code, so all existing code is already single-quoted and removing the
enforcement is a no-op.

Validation

  • pre-commit run --all-files exits 0 with no hook modifying any file
  • Hook inventory re-checked against origin/master

Checklist

  • The change is well-scoped and ready for review
  • I validated the touched files locally or with the available checks
  • Any downstream impact is documented in the PR description

double-quote-string-fixer forces single quotes while ruff-format forces
double quotes. Both hooks rewrite the same files, so pre-commit reports
"files were modified by this hook" and no committed state satisfies both.
Copilot AI balanced review requested due to automatic review settings October 4, 2026 12:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2026

Copy link
Copy Markdown

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@kilo-code-bot

kilo-code-bot Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Single-line deletion of the double-quote-string-fixer hook. The pre-commit/pre-commit-hooks block remains structurally valid YAML, ruff-format stays as the sole quote-style owner, and no remaining hook references the removed id.

Files Reviewed (1 files)
  • .pre-commit-config.yaml

Notes: no inline comments posted. Findings outside the changed (deleted) line were not anchored to nearby context lines.


Reviewed by free · Input: 36.7K · Output: 1.8K · Cached: 97.5K

@gvatsal60
gvatsal60 merged commit 7b4491a into master Oct 4, 2026
11 checks passed
@gvatsal60
gvatsal60 deleted the chore/remove-double-quote-string-fixer branch October 4, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants