Use MIT license#51
Conversation
[why] The LGPL imposes somewhat onerous burdens on users who would like to reuse parts of the library. Especially for a fundamental library like GUL17, this makes it harder than necessary to reuse the code. Switching to MIT facilitates reuse, but still requires that users acknowledge the origin of the code. [how] Replace the old license.txt with the MIT license in a markdown file LICENSE.md. Move our copyright and license information from the documentation website into README.md where it is much more accessible. The website just retains a copy of the license and a link to the README. Adjust some details of the main Doxygen page accordingly (e.g. move the list of contributors into README.md).
... and move gul17.spec into the data/ folder. There is no need for it to be in the root of the repository.
[why] We have put GUL17 under the MIT license.
[why] We have put our source code under the MIT license, so the file headers must reflect that.
alt-graph
requested review from
Finii,
Seim2k17,
ohensler,
soerengrunewald and
zykure
|
Here's the switch from LGPL-2.1 to MIT. Please have another look. |
There was a problem hiding this comment.
I guess you changed everything meticulously 👍
Personally I dislike these long long texts in source files, before the actual file contents starts. Like \file, I see the file, I dont need it repeated inside ;)
And what I would suggest is to use the SPDX license identifier instead of the full MIT text in the source files. I believe there is also some standard for that, but I can not find it right away.
Edit:
I mean something along these lines
/**
* \file doxygen.h
* \date Created on August 24, 2018
* \brief Doxygen input file for the General Utility Library.
*
* \copyright Copyright 2018-2026 Deutsches Elektronen-Synchrotron (DESY), Hamburg
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy of this
- * software and associated documentation files (the "Software"), to deal in the Software
- * without restriction, including without limitation the rights to use, copy, modify,
- * merge, publish, distribute, sublicense, and/or sell copies of the Software, and to
- * permit persons to whom the Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall be included in all copies
- * or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
- * INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A
- * PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF
- * CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR
- * THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ * \spdx-license: MIT
*/
/**
* Namespace gul17 contains all functions and classes of the General Utility Library.
*/
namespace gul17 {
That might be worth a thought, but I won't go for it in this MR. Next one, maybe... |
|
Since we seem to have consent from all authors, I'll merge. 🍾 |
|
💪 |
2 participants
As discussed in
with this PR we put GUL17 under the MIT license to improve the reusability of the code.
In detail, we replace the old license.txt with the LGPL-2.1 text by a LICENSE.md with the MIT text and move our copyright and license information from the documentation website into README.md where it is much more accessible. The website just retains a copy of the MIT license and links to the README. We also replace license information in file headers and other files where necessary.
Edit by Fini: Change how the link to PR 49 is shown