Skip to content

remove intent action and method for Orbot V2 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bitmold wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove intent action and method for Orbot V2 #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions libnetcipher/src/info/guardianproject/netcipher/proxy/OrbotHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,7 @@ public class OrbotHelper implements ProxyHelper {
public final static String STATUS_STARTS_DISABLED = "STARTS_DISABLED";

public final static String ACTION_START_TOR = "org.torproject.android.START_TOR";
/**
* Intent Action to request V2 Onion Services
* See {{@link #requestHiddenServiceOnPort(Activity, int)}}
*/
@Deprecated
public final static String ACTION_REQUEST_HS = "org.torproject.android.REQUEST_HS_PORT";

/**
* Intent Action to request V3 Onion Services
* See {{@link #requestV3OnionServiceOnPort(Activity, int, int, String)}}
Expand Down Expand Up @@ -196,20 +191,6 @@ private static boolean isAppInstalled(Context context, String uri) {
}
}

/**
* This method creates a V2 Onion Service which is being phased out by tor soon.
* Instead, you should use {{@link #requestV3OnionServiceOnPort(Activity, int, int, String)}}
* to create a V3 Onion Service. See https://blog.torproject.org/v2-deprecation-timeline
*/
@Deprecated
public static void requestHiddenServiceOnPort(Activity activity, int port) {
Intent intent = new Intent(ACTION_REQUEST_HS);
intent.setPackage(ORBOT_PACKAGE_NAME);
intent.putExtra("hs_port", port);

activity.startActivityForResult(intent, HS_REQUEST_CODE);
}

/**
* Tells Orbot to spin up a v3 Onion Service for your application
* @param activity
Expand Down