make return value of projectS3Image non-optional#4792
Open
andrew-nowak wants to merge 1 commit into
Open
Conversation
andrew-nowak
added
the
maintenance
andrew-nowak
force-pushed
the
an/minor-projection-code-simplification
branch
from
78a8756 to
ed1ea3a
Compare
andrew-nowak
force-pushed
the
an/minor-projection-code-simplification
branch
from
ed1ea3a to
0b802f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
I noticed that the return type of
projectS3ImageByIdisFuture[Option[Image]], but it always returns aFuture[Some[Image]](the branch where an image isn't found instead throws aNoSuchImageExistsInS3). Simplifying that return type toFuture[Image]reveals that the controller only gives helpful logging when it receives aNone(which as we saw above, it simply can't), so move the logging to the exception handler instead.How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?