Skip to content

Show football scorer info correctly - #16610

Open
Jakeii wants to merge 4 commits into
mainfrom
jlk/football-scorer-pill-styles
Open

Show football scorer info correctly#16610
Jakeii wants to merge 4 commits into
mainfrom
jlk/football-scorer-pill-styles

Conversation

@Jakeii

@Jakeii Jakeii commented Aug 26, 2026

Copy link
Copy Markdown
Member

What does this change?

Update the data parsing and styling to show the time scores happened in a pill

Why?

Looks nicer, and is in the original designs.

How has this change been tested?

I've updated the header stories to include scorers

chromatic diffs are expected

Screenshots

Before After
before after

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:38db30cefe98a9c3a91bd2d7732d869db5dd37e47e1b8cc16e481cdef122708b

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:38db30cefe98a9c3a91bd2d7732d869db5dd37e47e1b8cc16e481cdef122708b"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-jlk-football-scorer-pill-styles"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-30457"

# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-6e2bdf5244ecc2cdb312d22d764f36a7462a7dd7"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/deployTools --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-publish-image.

@Jakeii Jakeii added the feature Departmental tracking: work on a new feature label Aug 26, 2026
@Jakeii Jakeii added the run_chromatic Runs chromatic when label is applied label Aug 26, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Aug 26, 2026
@Jakeii
Jakeii marked this pull request as ready for review August 26, 2026 14:05
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Goal time rendering as plain text in football liveblog headers

2 participants