Gate editorial ab tests behind a feature switch - #16597
Open
abeddow91 wants to merge 2 commits into
Open
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Checks that the editorial ab testing feature switch has been enabled when deciding which headline to render. Feature switches are controlled via the Switchboard
In order to check this, feature switches have been prop drilled from the config through to the
enhanceCardfunction.The PR to add the feature switch to the switchboard can be found here guardian/frontend#29124
Why?
This is a safety mechanism to allow editorial ab testing to be turned off centrally, if required. This might be necessary, for example, in the event of a major incident.