Skip to content

Update PULL_REQUEST_TEMPLATE.md to add 'How has this change been tested?' section#16359

Draft
arelra wants to merge 2 commits into
mainfrom
arelra-patch-2
Draft

Update PULL_REQUEST_TEMPLATE.md to add 'How has this change been tested?' section#16359
arelra wants to merge 2 commits into
mainfrom
arelra-patch-2

Conversation

@arelra

@arelra arelra commented Jul 9, 2026

Copy link
Copy Markdown
Member

What does this change?

Update PULL_REQUEST_TEMPLATE.md to add 'How has this change been tested?' section

As noticed by @akash1810 we don't have a section calling out whether testing has occurred in contrast to the org default template:

https://github.com/guardian/.github/blob/main/PULL_REQUEST_TEMPLATE.md?plain=1

Why?

Highlight importance of tests, in particular automated tests.

@arelra arelra added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Jul 9, 2026

@akash1810 akash1810 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I don't think I should give explicit approval as I'm not in the immediate team, just a fly-by contributor for now 😄 . However, as a such a contributor, being reminded of the testing expectations is very helpful1!

Footnotes

  1. Apologies for the odd PR that I hadn't fully tested 😅 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants