grpc-tools: Update protoc to v3.19.1

[natiz]

No description provided.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: natiz / name: natiz (1247129)

[murgatroid99]

It's not that simple to make this upgrade. See my comment at #2155 (comment)

[natiz]

Thanks for pointing it out!

I've set it v3.19.1 which seems to be the last release that includes javascript changes.
I am specifically interested in protocolbuffers/protobuf#8864 which is included in v3.19.0

[murgatroid99]

That should be fine, but unfortunately I can't accept any change without the EasyCLA check. Please fix that.

[murgatroid99]

Also, it looks like the gRPC plugin failed to build on Windows because of some link errors.

[natiz]

I think its related to protocolbuffers/protobuf@c47adad (and this), but fiddling in the dark here. I'll try to resolve it.

[natiz]

Fixed the windows build

[murgatroid99]

I had to push a fix for the Linux build. Can you merge from master to pick it up?

[murgatroid99]

That cmake_minimum_required(VERSION 3.15) line is going to be an issue. We want to run the build on the oldest possible Debian LTS release, for maximum compatibility, but the latest Debian LTS version is Buster, which only has cmake 3.13.4.

[natiz]

Updated to 3.7, since I got this for 3.13: CMake 3.13 or higher is required. You are running version 3.7.2

[murgatroid99]

OK, it works. Can you also update the version in the package.json to 1.12.0 so that I can publish the change immediately?

[natiz]

Sure, bumped.

[murgatroid99]

Thank you for your contribution.

[murgatroid99]

I have published this in version 1.12.0.

[natiz]

Looks like there is an issue with the binaries in 1.12.0, they are placed in a subfolder GNUSparseFile.0, which causes an ENOENT failure on bin/protoc.

1.12.0:

> find node_modules/grpc-tools/bin
node_modules/grpc-tools/bin
node_modules/grpc-tools/bin/protoc.js
node_modules/grpc-tools/bin/google
node_modules/grpc-tools/bin/google/protobuf
node_modules/grpc-tools/bin/google/protobuf/timestamp.proto
node_modules/grpc-tools/bin/google/protobuf/field_mask.proto
node_modules/grpc-tools/bin/google/protobuf/api.proto
node_modules/grpc-tools/bin/google/protobuf/duration.proto
node_modules/grpc-tools/bin/google/protobuf/struct.proto
node_modules/grpc-tools/bin/google/protobuf/wrappers.proto
node_modules/grpc-tools/bin/google/protobuf/source_context.proto
node_modules/grpc-tools/bin/google/protobuf/any.proto
node_modules/grpc-tools/bin/google/protobuf/type.proto
node_modules/grpc-tools/bin/google/protobuf/empty.proto
node_modules/grpc-tools/bin/google/protobuf/compiler
node_modules/grpc-tools/bin/google/protobuf/compiler/plugin.proto
node_modules/grpc-tools/bin/google/protobuf/descriptor.proto
node_modules/grpc-tools/bin/GNUSparseFile.0
node_modules/grpc-tools/bin/GNUSparseFile.0/grpc_node_plugin
node_modules/grpc-tools/bin/GNUSparseFile.0/protoc
node_modules/grpc-tools/bin/protoc_plugin.js

1.11.3:

> find node_modules/grpc-tools/bin
node_modules/grpc-tools/bin
node_modules/grpc-tools/bin/grpc_node_plugin
node_modules/grpc-tools/bin/protoc.js
node_modules/grpc-tools/bin/google
node_modules/grpc-tools/bin/google/protobuf
node_modules/grpc-tools/bin/google/protobuf/timestamp.proto
node_modules/grpc-tools/bin/google/protobuf/field_mask.proto
node_modules/grpc-tools/bin/google/protobuf/api.proto
node_modules/grpc-tools/bin/google/protobuf/duration.proto
node_modules/grpc-tools/bin/google/protobuf/struct.proto
node_modules/grpc-tools/bin/google/protobuf/wrappers.proto
node_modules/grpc-tools/bin/google/protobuf/source_context.proto
node_modules/grpc-tools/bin/google/protobuf/any.proto
node_modules/grpc-tools/bin/google/protobuf/type.proto
node_modules/grpc-tools/bin/google/protobuf/empty.proto
node_modules/grpc-tools/bin/google/protobuf/compiler
node_modules/grpc-tools/bin/google/protobuf/compiler/plugin.proto
node_modules/grpc-tools/bin/google/protobuf/descriptor.proto
node_modules/grpc-tools/bin/protoc
node_modules/grpc-tools/bin/protoc_plugin.js