Conversation
`transportHeadersReceived()` already reset the stream when trailers arrived before the client finished sending, but it used `isOutboundClosed()` as a stand-in for "END_STREAM has been sent". Those differ whenever END_STREAM is still waiting on flow control: the application has half-closed, yet the frame sits in the remote flow controller. If the server responded and closed the call without reading the rest of the request, it stops returning window, so END_STREAM can never be written and neither side resets the stream. Decide the reset on the HTTP/2 stream's local state instead, which is only closed once END_STREAM has actually been written. Fixes grpc#13078.
benjaminp
changed the title
AgraVator
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
Contributor
|
Hey, can you please add some test which covers all the branches ? |
Contributor
Author
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transportHeadersReceived()already reset the stream when trailers arrived before the client finished sending, but it usedisOutboundClosed()as a stand-in for "END_STREAM has been sent". Those differ whenever END_STREAM is still waiting on flow control: the application has half-closed, yet the frame sits in the remote flow controller. If the server responded and closed the call without reading the rest of the request, it stops returning window, so END_STREAM can never be written and neither side resets the stream.Decide the reset on the HTTP/2 stream's local state instead, which is only closed once END_STREAM has actually been written.
Fixes #13078.