Update vcfpy dependency to a newer version #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susannasiebert
force-pushed
the
vcfpy_version
branch
from
a4eb825 to
fd59b98
Compare
chrisamiller
approved these changes
Jan 30, 2026
Collaborator
chrisamiller
left a comment
chrisamiller
left a comment
There was a problem hiding this comment.
It seems odd that there isn't a cleaner way to do the whole repeated if self.REGNERATE_TEST_DATA thing, but I don't have one off the top of my head, so seems fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updated VCFpy version no longer encodes certain special characters so a lot of test files are updated to reflect this. This update also add python 3.12 as a test python version for the GitHub action.