Two Node.FileSystem bug fixes + test cases - #52
Merged
Conversation
robinheghan
approved these changes
Jul 31, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in the FileSystem.writeFileStream JS kernel (src/Gren/Kernel/FileSystem.js) and adds an integration test suite covering some of the FileSystem API.
Bug 1: Append mode crashes with ERR_OUT_OF_RANGE
writeFileStream encodes its mode as an integer pos: 0 = Replace, -1 = Append, n > 0 = ReplaceFrom n. The start option was computed in the kernel as:
start: pos === 0 ? undefined : pos
For Append (pos = -1) this passed start: -1 to fs.createWriteStream, which Node rejects with ERR_OUT_OF_RANGE, throwing synchronously and failing the Task before any bytes are written.
Fix (384a660): widen the guard to cover both non-offset modes:
start: pos <= 0 ? undefined : pos
Bug 2: writeFileStream using the mode ReplaceFrom leaves trailing bytes from the original file if the original file's length is greater than the written value.
ReplaceFrom nopens the file with flags: "r+" and start: n. createWriteStream writes at the offset but does not truncate, so when the new payload is shorter than the suffix it replaces, stale bytes remain:Fix (76b572): once the stream drains, truncate the file to the prefix length plus what was written:
if (pos > 0) {
fstream.on("finish", function () {
fs.truncate(filePath, pos + fstream.bytesWritten, (_) => {});
});
}
Tests