-
Notifications
You must be signed in to change notification settings - Fork 41
Clearer container limit info #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ies to container tab; Renamed usage_scenario_dependencies to container_dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 files reviewed, 3 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11 files reviewed, 1 comment
| measurement_config jsonb, | ||
| start_measurement bigint, | ||
| end_measurement bigint, | ||
| containers jsonb, -- explicitely not null as entry in runs table gets created first. then filled. so NULL is different info than {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: typo: 'explicitly' is misspelled as 'explicitely'
| containers jsonb, -- explicitely not null as entry in runs table gets created first. then filled. so NULL is different info than {} | |
| containers jsonb, -- explicitly not null as entry in runs table gets created first. then filled. so NULL is different info than {} |
Greptile Overview
Greptile Summary
This PR refactors container information display by introducing a dedicated "Containers" tab and renaming
usage_scenario_dependenciestocontainer_dependenciesfor better clarity. The changes include database schema updates through migrations, frontend UI reorganization with a new tab, and backend data storage modifications.The refactoring separates container metadata (ID, name, CPU/memory limits) from dependency information, improving the user experience by organizing related information in dedicated UI sections. The changes span across database schema, scenario runner logic, frontend display components, and test files to maintain consistency.
Critical Issues Found:
mem_limitfield that can be either a string ("1G") or integer (bytes), potentially resulting inNaNvalues when displaying memory informationConfidence Score: 2/5 - While the refactoring improves code organization, the critical security vulnerability and logic errors require immediate attention before merging.