test: fix lazy-font race condition in expectScreenshot#1053
Open
makhnatkin wants to merge 1 commit intomainfrom
Open
test: fix lazy-font race condition in expectScreenshot#1053makhnatkin wants to merge 1 commit intomainfrom
expectScreenshot#1053makhnatkin wants to merge 1 commit intomainfrom
Conversation
|
|
|
|
makhnatkin
force-pushed
the
chore/fix-flapy-test
branch
4 times, most recently
from
420dd80 to
3ee0cc7
Compare
makhnatkin
changed the title
makhnatkin
changed the title
makhnatkin
changed the title
expectScreenshot
makhnatkin
force-pushed
the
chore/fix-flapy-test
branch
from
3ee0cc7 to
0d3e969
Compare
makhnatkin
changed the title
expectScreenshotexpectScreenshot
makhnatkin
force-pushed
the
chore/fix-flapy-test
branch
4 times, most recently
from
ab2e7d7 to
35328a4
Compare
makhnatkin
force-pushed
the
chore/fix-flapy-test
branch
from
35328a4 to
8b1743d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubuntu Mono fontstackwaitForLoadState('networkidle')beforedocument.fonts.readyinexpectScreenshot. This ensures lazy CSS chunks finish loading and their font file downloads settle before fonts readiness is checked, sodocument.fonts.readyeither resolves immediately or waits only for already-tracked requests.