perf(core): add document-level and block-level caching to pm→markdown serialization#1047
Merged
perf(core): add document-level and block-level caching to pm→markdown serialization#1047
Conversation
|
|
|
|
d3m1d0v
changed the title
Repeated serialize() calls with the same document node and equivalent options now return the cached result without re-serialization. Options are compared by reference first, then field-by-field (with RegExp support via source+flags).
When the document changes, only modified top-level blocks are re-serialized. Unchanged blocks (same node reference) reuse their cached output. Cache validity also accounts for the preceding block type, which affects inter-block separators (e.g. triple newline between consecutive lists of the same type).
makhnatkin
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two-level caching in
MarkdownSerializer:serialize()is called with the samedocnode and equivalentoptions, returns the cached result without re-serializationWeakMapcacheOptions are compared using a hybrid approach: reference equality first (
===), then field-by-field with RegExp support.