Skip to content

fix: transform only local scss imports#10

Open
d3m1d0v wants to merge 1 commit into
mainfrom
fix-scss-imports
Open

fix: transform only local scss imports#10
d3m1d0v wants to merge 1 commit into
mainfrom
fix-scss-imports

Conversation

@d3m1d0v

@d3m1d0v d3m1d0v commented Feb 25, 2025

Copy link
Copy Markdown
Member

TSC should not transform scss imports from external packages

@d3m1d0v
d3m1d0v requested a review from ValeraS February 25, 2025 16:19

@ValeraS ValeraS left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Why do you convert scss to css and continue to use scss imports from other libraries? Maybe you don't need this transformer at all.

@d3m1d0v

d3m1d0v commented Feb 26, 2025

Copy link
Copy Markdown
Member Author

Hi! Why do you convert scss to css and continue to use scss imports from other libraries? Maybe you don't need this transformer at all.

Because external library export styles as scss

@ValeraS

ValeraS commented Feb 26, 2025

Copy link
Copy Markdown
Collaborator

Hi! Why do you convert scss to css and continue to use scss imports from other libraries? Maybe you don't need this transformer at all.

Because external library export styles as scss

Yes, but why are you converting your styles? It seems pointless because the user still needs to use the sccs loader to use your library.

By the way, which library exports styles only as scss?

@d3m1d0v

d3m1d0v commented Feb 26, 2025

Copy link
Copy Markdown
Member Author

By the way, which library exports styles only as scss?

Its internal library that does not have a style build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants