feat: add Playwright page objects#327
Draft
draedful wants to merge 1 commit into
Draft
Conversation
Reviewer's GuideAdds a new public Playwright testing subpath with graph-focused page objects, introduces a namespaced DOM bridge for resolving graph instances from application locators, wires the bridge into Graph attach/detach lifecycle, and documents and tests the new API. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Preview is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@gravity-ui/graph/playwrightsubpath with page objects for graphs, blocks, connections, and camera controls@playwright/testoptional for regular library consumersWhy
Graph entities are rendered on canvas, so application tests cannot reliably locate blocks and connections through DOM selectors. The new page objects provide stable, typed interactions in world coordinates without requiring applications to expose a global
window.graph.Developer impact
Existing package entry points remain unchanged. Consumers that use the new subpath should install
@playwright/testas a development dependency and constructGraphPOwith a locator containing exactly one graph.Validation
tsc -p tsconfig.publish.json --noEmitnpm test— 31 suites passed, 341 tests passednpm run test:e2e -- e2e/tests/playwright-page-object.spec.ts— 2 tests passednpm run build:publishSummary by Sourcery
Add a public Playwright testing entry point with page objects and a DOM graph instance bridge for canvas-rendered graphs.
New Features:
@gravity-ui/graph/playwrightsubpath exporting page objects for graphs, blocks, connections, and camera interactions.Bug Fixes:
Enhancements:
Build:
exportsandtypesVersions, and declare@playwright/testas an optional peer dependency.Tests: