New events and meetups #2230
New events and meetups #2230
Conversation
| onPointerLeave={handlePointerLeave} | ||
| onClick={handleMapClick} | ||
| > | ||
| <canvas |
There was a problem hiding this comment.
Jon asked me a good question in DMs, so I'll note it here for posterity.
This WebGL stuff is complicated. Why didn't you do it in the DOM?
I did initially, but it turns out that rendering a lot of squares in the DOM is sorta expensive and didn't feel great on my laptop. I started getting into virtualization and reusing divs, but realized this can be written with a shader. A simpler implementation with a static image and an overlay with markers exists, but we kinda need zooming because a lot of the meetups are very close to each other.
jonathanawesome
left a comment
jonathanawesome
left a comment
There was a problem hiding this comment.
Whoa, that's a lot of new code!
I haven't been through all of the map code in detail, but it's performant in the preview and all of the meetup nodes are generally in the correct location.
2 participants
Description
Refreshed the events page according to Figma.
I'll do a follow up PR with the
Add an event, issue template, and possibly "load more" instead of a scrollview, because this is big enough already and I'd rather keep the convo about the event proposal issue template separate from the code review of this page.Screen.Recording.2025-11-12.at.21.13.16.mov