fix(allocations): pass SubgraphService as rewards issuer#1204
Open
RembrandtK wants to merge 1 commit intomain-dipsfrom
Open
fix(allocations): pass SubgraphService as rewards issuer#1204RembrandtK wants to merge 1 commit intomain-dipsfrom
RembrandtK wants to merge 1 commit intomain-dipsfrom
Conversation
Contributor
Author
|
I was under impression already on some branches at least, but seems not commited to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RewardsManager auth check requires the rewards issuer argument to equal subgraphService. Passing HorizonStaking instead triggers "Not a rewards issuer" revert during stakeUsageSummary, which blocks unallocate/reallocate/resize actions from ever being submitted.
Main branch fix: #1195