core: Remove error return from IndexingContext.revert_data_sources#6423
Closed
core: Remove error return from IndexingContext.revert_data_sources#6423
Conversation
lutter
force-pushed
the
lutter/revert-err
branch
2 times, most recently
from
5a093ab to
d2ef4b3
Compare
incrypto32
approved these changes
Mar 9, 2026
lutter
force-pushed
the
lutter/revert-err
branch
from
d2ef4b3 to
4db386b
Compare
Collaborator
Author
|
I screwed up some git commands. This was merged as 4db386b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unnecessary return makes callers look like they could fail
Just a small code clarification as I was looking at #6422